All of lore.kernel.org
 help / color / mirror / Atom feed
From: "pascal@pabr.org" <pascal@pabr.org>
To: linux-input@vger.kernel.org
Subject: Re: hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis
Date: Wed, 01 Dec 2010 23:40:37 +0100	[thread overview]
Message-ID: <id6itu$i3q$1@dough.gmane.org> (raw)
In-Reply-To: <20101201220635.ccba6b58.ospite@studenti.unina.it>

Antonio Ospite wrote:
> The non-standard USB behavior made me think that the patch proposed
> could not be an actual fix but another non-standard sixaxis quirk;

That sounds right; I hadn't noticed hid-sony.c overriding
usbhid_output_raw_report().  Maybe it should simply override
hidp_output_raw_report() as well.

And maybe the default hidp_output_raw_report() should be
patched to behave like the default usbhid_output_raw_report(),
for the sake of consistency.

I am not sure you will find a final answer in the HID spec, but
the default usbhid_output_raw_report() certainly makes sense:
Send OUTPUT reports as interrupt messages because this is more
efficient e.g. for streaming reports to force-feedback devices;
and use the control channel only when the spec leaves no other
choice, i.e. for other report types.

Of course there is also the option of adding a specific function
in struct hid_device for transactions on the control channel.
That would be a good opportunity to enforce section 7.9.1
("no more than one outstanding request on the control channel")
and to implement callbacks for handshake results; but currently
nobody needs these features AFAIK.

Pascal


  reply	other threads:[~2010-12-01 22:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 13:54 hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis Antonio Ospite
2010-11-30 13:54 ` Antonio Ospite
2010-11-30 14:06 ` Antonio Ospite
2010-11-30 17:40 ` pascal
2010-12-01 21:06   ` Antonio Ospite
2010-12-01 22:40     ` pascal [this message]
2011-02-17 14:19   ` Antonio Ospite
2011-02-17 14:19     ` Antonio Ospite
2011-02-18  8:45     ` Jiri Kosina
2011-02-18  8:45       ` Jiri Kosina
2011-02-20 17:26       ` [PATCH 0/2] Fix sending Output reports to the Sony Sixaxis Antonio Ospite
2011-02-20 17:26         ` [PATCH 1/2] hid-sony.c: Fix sending Output reports to the Sixaxis Antonio Ospite
2011-02-21 12:49           ` Jiri Kosina
2011-02-20 17:26         ` [PATCH 2/2] bt hidp: send Output reports using SET_REPORT on the Control channel Antonio Ospite
2011-02-21  3:45           ` Alan Ott
2011-02-21  3:45             ` Alan Ott
2011-02-21 12:50             ` Jiri Kosina
2011-02-21 21:09               ` Gustavo F. Padovan
2011-02-22 10:09                 ` Jiri Kosina
2011-02-22 10:09                   ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='id6itu$i3q$1@dough.gmane.org' \
    --to=pascal@pabr.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.