Re: [PATCHv2] kernel/module-base: Append PR to MACHINE_KERNEL_PR

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04-04-11 17:14, Andreas Oberritter wrote:
> On 04/04/2011 03:58 PM, Koen Kooi wrote:
>> On 04-04-11 15:00, Andreas Oberritter wrote:
>>> Ping. Any votes for or against this patch with either appended or
>>> prepended PR?
>>
>> I don't like this patch *at all*. Recipes can already do
>> MACHINE_KERNEL_PR_append = "something" if they need to.
> 
> The use of MACHINE_KERNEL_PR is optional, so it feels really wrong to
> append something to it in a recipe.
> 
>> Can you should me a specific example on how this would be an improvement?
> 
> With the version below. a distro can start to use MACHINE_KERNEL_PR any
> time without breaking updates.
> 
> The vast majority of modules do not use MACHINE_KERNEL_PR

It seems you don't understand how MACHINE_KERNEL_PR works. The *machine*
sets it. The distro has *no* say in it. Therefore the module recipes
don't need to set it, since it's automatic.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNmgXgMkyGM64RGpERAr9CAJ9urNa16wfGmCwh4/NvUZd4GOUm2wCfcCrV
Q4CvioBpYYMC4bjEHL4cUD0=
=t85H
-----END PGP SIGNATURE-----