Re: [PATCH] wvstreams: Added recipe for wxstreams 4.6.1.

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25-04-11 11:57, Søren Holm wrote:

> +LICENSE = "LGPL"

That needs a version number, e.g. LGPLv2.1

> +DEPENDS = "zlib openssl (>= 0.9.8)"

There's no < 0.9.8 in the tree anymore

> +# dbus detection currently broken in configure.ac; remember to add "dbus (>= 1.2.14)" to DEPENDS  when fixed

has it been fixed?

> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"

The pam stuff needs to be converted into something like:

DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"

${@base_contains('DISTRO_FEATURES', 'pam', '--with-pam',
'--without-pam', d)}

> +
> +PACKAGES_prepend = "libuniconf libuniconf-dbg "
> +PACKAGES_prepend = "uniconfd uniconfd-dbg "
> +PACKAGES_prepend = "libwvstreams-base libwvstreams-base-dbg "
> +PACKAGES_prepend = "libwvstreams-extras libwvstreams-extras-dbg "

Change that to a single PACKAGES =+


> +do_configure() {
> +        autoreconf
> +        oe_runconf
> +}

Why not stock autotools_do_configure?

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNtUdGMkyGM64RGpERAsajAJ9nepgViPPFhbWwsS2AchhCw/tlBACfbVUa
JdSqbThI5m5aFsEd0cajYB4=
=gUZN
-----END PGP SIGNATURE-----