From: WANG Cong <xiyou.wangcong@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] package: Makefile: fix perf target bug
Date: Fri, 13 May 2011 05:22:20 +0000 (UTC) [thread overview]
Message-ID: <iqif6b$rg0$1@dough.gmane.org> (raw)
In-Reply-To: e5dfdb7d9a9909d6f9faa20c45115142ebce2ae2.1305244842.git.mfm@muteddisk.com
On Thu, 12 May 2011 17:09:03 -0700, mfmooney wrote:
> From: matt mooney <mfm@muteddisk.com>
>
> Specify --git-dir and --work-tree when building perf targets to allow
> out-of-tree builds using O=<build-dir>.
>
> The cat command had to be changed to allow proper file name expansion of
> the files listed in MANIFEST.
>
> Signed-off-by: matt mooney <mfm@muteddisk.com> ---
> Okay, so I decided to just go ahead and send this. It removes the
> --work-tree option from the git rev-parse command. I did test it the way
> you said, without --work-tree on either statement, but the git archive
> command fails in that case.
>
Looks like `git rev-parse` only needs the data in .git to work fine,
so this patch looks good to me,
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
BTW, I think you need to Cc Ingo and Peter for perf changes.
Thanks.
next prev parent reply other threads:[~2011-05-13 5:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 18:25 [Resend PATCH] package: Makefile: fix perf target bug mfmooney
2011-05-12 18:25 ` mfmooney
2011-05-12 20:30 ` Michal Marek
2011-05-12 20:30 ` Michal Marek
2011-05-12 21:07 ` matt mooney
2011-05-12 21:07 ` matt mooney
2011-05-12 21:07 ` matt mooney
2011-05-12 21:20 ` Michal Marek
2011-05-12 21:20 ` Michal Marek
2011-05-12 21:38 ` matt mooney
2011-05-12 21:38 ` matt mooney
2011-05-13 0:09 ` [PATCH v2] " mfmooney
2011-05-13 0:09 ` mfmooney
2011-05-13 5:22 ` WANG Cong [this message]
2011-05-13 8:26 ` [Resend PATCH] " Michal Marek
2011-05-13 8:26 ` Michal Marek
2011-05-13 18:52 ` matt mooney
2011-05-13 18:52 ` matt mooney
2011-05-13 19:56 ` Michal Marek
2011-05-13 19:56 ` Michal Marek
2011-05-13 23:26 ` matt mooney
2011-05-13 23:26 ` matt mooney
2011-05-13 23:41 ` [PATCH v3] " mfmooney
2011-05-13 23:41 ` mfmooney
2011-05-15 15:40 ` Arnaldo Carvalho de Melo
2011-05-15 15:40 ` Arnaldo Carvalho de Melo
2011-05-16 8:19 ` Michal Marek
2011-05-16 8:19 ` Michal Marek
2011-06-12 18:19 ` matt mooney
2011-06-12 18:19 ` matt mooney
2011-06-24 13:22 ` Michal Marek
2011-06-24 13:22 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='iqif6b$rg0$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.