From: Michal Marek <mmarek@suse.cz>
To: matt mooney <mfmooney@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [Resend PATCH] package: Makefile: fix perf target bug
Date: Fri, 13 May 2011 19:56:20 +0000 [thread overview]
Message-ID: <4DCD8CE4.4090404@suse.cz> (raw)
In-Reply-To: <BANLkTimcs83J3O8o7npLftBaQk1WKKZ=2Q@mail.gmail.com>
On 13.5.2011 20:52, matt mooney wrote:
> So the real problem is that tools/perf/MANIFEST contains wildcards,
> and when git archive is run, file name expansion isn't working
> properly. By adding the $(srctree) as a prefix, globbing works but
> then git archive requires --work-tree to be set.
I see. So how about
git --git-dir=$(srctree)/.git archive ... \
$$(cd $(srctree); echo $$(cat tools/perf/MANIFEST))
? That does exactly the same as before the patch, just changes to
$(srctree) so that the expansion works.
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: matt mooney <mfmooney@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [Resend PATCH] package: Makefile: fix perf target bug
Date: Fri, 13 May 2011 21:56:20 +0200 [thread overview]
Message-ID: <4DCD8CE4.4090404@suse.cz> (raw)
In-Reply-To: <BANLkTimcs83J3O8o7npLftBaQk1WKKZ=2Q@mail.gmail.com>
On 13.5.2011 20:52, matt mooney wrote:
> So the real problem is that tools/perf/MANIFEST contains wildcards,
> and when git archive is run, file name expansion isn't working
> properly. By adding the $(srctree) as a prefix, globbing works but
> then git archive requires --work-tree to be set.
I see. So how about
git --git-dir=$(srctree)/.git archive ... \
$$(cd $(srctree); echo $$(cat tools/perf/MANIFEST))
? That does exactly the same as before the patch, just changes to
$(srctree) so that the expansion works.
Michal
next prev parent reply other threads:[~2011-05-13 19:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 18:25 [Resend PATCH] package: Makefile: fix perf target bug mfmooney
2011-05-12 18:25 ` mfmooney
2011-05-12 20:30 ` Michal Marek
2011-05-12 20:30 ` Michal Marek
2011-05-12 21:07 ` matt mooney
2011-05-12 21:07 ` matt mooney
2011-05-12 21:07 ` matt mooney
2011-05-12 21:20 ` Michal Marek
2011-05-12 21:20 ` Michal Marek
2011-05-12 21:38 ` matt mooney
2011-05-12 21:38 ` matt mooney
2011-05-13 0:09 ` [PATCH v2] " mfmooney
2011-05-13 0:09 ` mfmooney
2011-05-13 5:22 ` WANG Cong
2011-05-13 8:26 ` [Resend PATCH] " Michal Marek
2011-05-13 8:26 ` Michal Marek
2011-05-13 18:52 ` matt mooney
2011-05-13 18:52 ` matt mooney
2011-05-13 19:56 ` Michal Marek [this message]
2011-05-13 19:56 ` Michal Marek
2011-05-13 23:26 ` matt mooney
2011-05-13 23:26 ` matt mooney
2011-05-13 23:41 ` [PATCH v3] " mfmooney
2011-05-13 23:41 ` mfmooney
2011-05-15 15:40 ` Arnaldo Carvalho de Melo
2011-05-15 15:40 ` Arnaldo Carvalho de Melo
2011-05-16 8:19 ` Michal Marek
2011-05-16 8:19 ` Michal Marek
2011-06-12 18:19 ` matt mooney
2011-06-12 18:19 ` matt mooney
2011-06-24 13:22 ` Michal Marek
2011-06-24 13:22 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCD8CE4.4090404@suse.cz \
--to=mmarek@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfmooney@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.