From: WANG Cong <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [net-next RFC PATCH 7/7] virtio-net changes
Date: Wed, 17 Aug 2011 13:24:59 +0000 (UTC) [thread overview]
Message-ID: <j2gff7$cn1$1@dough.gmane.org> (raw)
In-Reply-To: 20110812015551.31613.13885.stgit@intel-e5620-16-2.englab.nay.redhat.com
On Fri, 12 Aug 2011 09:55:51 +0800, Jason Wang wrote:
> From: Krishna Kumar <krkumar2@in.ibm.com>
>
> Implement mq virtio-net driver.
>
> Though struct virtio_net_config changes, it works with the old qemu
> since the last element is not accessed unless qemu sets
> VIRTIO_NET_F_MULTIQUEUE.
>
...
> +
> +#if 1
<...>
> +#else
<...>
> +#endif
Any reason to keep this #else code of #if 1? which is dead.
WARNING: multiple messages have this Message-ID (diff)
From: WANG Cong <xiyou.wangcong@gmail.com>
To: qemu-devel@nongnu.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [net-next RFC PATCH 7/7] virtio-net changes
Date: Wed, 17 Aug 2011 13:24:59 +0000 (UTC) [thread overview]
Message-ID: <j2gff7$cn1$1@dough.gmane.org> (raw)
In-Reply-To: 20110812015551.31613.13885.stgit@intel-e5620-16-2.englab.nay.redhat.com
On Fri, 12 Aug 2011 09:55:51 +0800, Jason Wang wrote:
> From: Krishna Kumar <krkumar2@in.ibm.com>
>
> Implement mq virtio-net driver.
>
> Though struct virtio_net_config changes, it works with the old qemu
> since the last element is not accessed unless qemu sets
> VIRTIO_NET_F_MULTIQUEUE.
>
...
> +
> +#if 1
<...>
> +#else
<...>
> +#endif
Any reason to keep this #else code of #if 1? which is dead.
next prev parent reply other threads:[~2011-08-17 13:24 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 1:54 [net-next RFC PATCH 0/7] multiqueue support for tun/tap Jason Wang
2011-08-12 1:54 ` [Qemu-devel] " Jason Wang
2011-08-12 1:54 ` [net-next RFC PATCH 1/7] tuntap: move socket/sock related structures to tun_file Jason Wang
2011-08-12 1:54 ` Jason Wang
2011-08-12 1:54 ` [Qemu-devel] " Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 2/7] tuntap: categorize ioctl Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 3/7] tuntap: introduce multiqueue related flags Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 4/7] tuntap: multiqueue support Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 14:29 ` Eric Dumazet
2011-08-12 14:29 ` Eric Dumazet
2011-08-12 14:29 ` [Qemu-devel] " Eric Dumazet
2011-08-12 14:29 ` Eric Dumazet
2011-08-14 6:05 ` Jason Wang
2011-08-14 6:05 ` [Qemu-devel] " Jason Wang
2011-08-14 6:05 ` Jason Wang
2011-08-14 6:05 ` Jason Wang
2011-08-12 23:21 ` Paul E. McKenney
2011-08-12 23:21 ` Paul E. McKenney
2011-08-12 23:21 ` [Qemu-devel] " Paul E. McKenney
2011-08-12 23:21 ` Paul E. McKenney
2011-08-14 6:07 ` Jason Wang
2011-08-14 6:07 ` Jason Wang
2011-08-14 6:07 ` [Qemu-devel] " Jason Wang
2011-08-14 6:07 ` Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 5/7] tuntap: add ioctls to attach or detach a file form tap device Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 6/7] Change virtqueue structure Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 1:55 ` [net-next RFC PATCH 7/7] virtio-net changes Jason Wang
2011-08-12 1:55 ` Jason Wang
2011-08-12 1:55 ` [Qemu-devel] " Jason Wang
2011-08-12 9:09 ` Sasha Levin
2011-08-12 9:09 ` Sasha Levin
2011-08-12 9:09 ` Sasha Levin
2011-08-14 5:59 ` [Qemu-devel] " Jason Wang
2011-08-14 5:59 ` Jason Wang
2011-08-14 5:59 ` Jason Wang
2011-08-14 5:59 ` Jason Wang
2011-08-12 9:09 ` [Qemu-devel] " Sasha Levin
2011-08-17 13:24 ` WANG Cong [this message]
2011-08-17 13:24 ` WANG Cong
2011-08-12 2:11 ` [net-next RFC PATCH 0/7] multiqueue support for tun/tap Jason Wang
2011-08-12 2:11 ` Jason Wang
2011-08-12 2:11 ` [Qemu-devel] " Jason Wang
2011-08-12 2:11 ` Jason Wang
2011-08-13 0:46 ` Sridhar Samudrala
2011-08-13 0:46 ` Sridhar Samudrala
2011-08-13 0:46 ` [Qemu-devel] " Sridhar Samudrala
2011-08-14 6:19 ` Jason Wang
2011-08-14 6:19 ` [Qemu-devel] " Jason Wang
2011-08-14 6:19 ` Jason Wang
2011-08-14 6:19 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j2gff7$cn1$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.