From: Andreas Schwab <schwab@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: Fix PowerMac sound i2c
Date: Sun, 08 Jan 2006 11:37:12 +0100 [thread overview]
Message-ID: <jefynz0zvr.fsf@sykes.suse.de> (raw)
In-Reply-To: <1136695956.30123.44.camel@localhost.localdomain> (Benjamin Herrenschmidt's message of "Sun, 08 Jan 2006 15:52:36 +1100")
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> My patch reworking the PowerMac i2c code break the sound drivers as they
> used to rely on some broken behaviour of i2c-keywest that is gone now.
I'm not sure, but from looking at the other i2c drivers I'd rather think
that the old behaviour of i2c-keywest was correct. There are only a few
that implement both I2C_SMBUS_BLOCK_DATA and I2C_SMBUS_I2C_BLOCK_DATA, but
none of them write the length byte together with the data. The commands
are ony different in behaviour when reading: with I2C_SMBUS_I2C_BLOCK_DATA
a fixed sized block is read from the bus, whereas with
I2C_SMBUS_BLOCK_DATA the size of the block is variable. At least that's
how i2c-nforce2, i2c-viapro and i2c-amd8111 implement the commands.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-01-08 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 4:52 [PATCH] powerpc: Fix PowerMac sound i2c Benjamin Herrenschmidt
2006-01-08 4:55 ` Hollis Blanchard
2006-01-08 6:22 ` Benjamin Herrenschmidt
2006-01-08 23:37 ` Benjamin Herrenschmidt
2006-01-08 10:37 ` Andreas Schwab [this message]
2006-01-08 13:30 ` Andreas Schwab
2006-01-08 21:03 ` Benjamin Herrenschmidt
2006-02-04 18:26 ` Paul Collins
2006-02-04 22:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jefynz0zvr.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.