From: Andreas Schwab <schwab@suse.de>
To: Satya <satyakiran@gmail.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: pte_offset_map for ppc assumes HIGHPTE
Date: Thu, 26 Jul 2007 01:18:48 +0200 [thread overview]
Message-ID: <jewswodqcn.fsf@sykes.suse.de> (raw)
In-Reply-To: <acbcf3840707251516w301f834cj5f6a81a494d359ed@mail.gmail.com> (Satya's message of "Wed\, 25 Jul 2007 17\:16\:01 -0500")
Satya <satyakiran@gmail.com> writes:
> hello,
> The implementation of pte_offset_map() for ppc assumes that PTEs are
> kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of
> pte_offset_map() as follows (include/asm-ppc/pgtable.h):
>
> #define pte_offset_map(dir, addr) \
> ((pte_t *) kmap_atomic(pmd_page(*(dir)), KM_PTE0) + pte_index(addr))
>
> Shouldn't this be made conditional according to CONFIG_HIGHPTE is
> defined or not
kmap_atomic is always defined with or without CONFIG_HIGHPTE.
> (as implemented in include/asm-i386/pgtable.h) ?
I don't think that needs it either.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Satya <satyakiran@gmail.com>
Cc: linuxppc-dev@ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: pte_offset_map for ppc assumes HIGHPTE
Date: Thu, 26 Jul 2007 01:18:48 +0200 [thread overview]
Message-ID: <jewswodqcn.fsf@sykes.suse.de> (raw)
In-Reply-To: <acbcf3840707251516w301f834cj5f6a81a494d359ed@mail.gmail.com> (Satya's message of "Wed\, 25 Jul 2007 17\:16\:01 -0500")
Satya <satyakiran@gmail.com> writes:
> hello,
> The implementation of pte_offset_map() for ppc assumes that PTEs are
> kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of
> pte_offset_map() as follows (include/asm-ppc/pgtable.h):
>
> #define pte_offset_map(dir, addr) \
> ((pte_t *) kmap_atomic(pmd_page(*(dir)), KM_PTE0) + pte_index(addr))
>
> Shouldn't this be made conditional according to CONFIG_HIGHPTE is
> defined or not
kmap_atomic is always defined with or without CONFIG_HIGHPTE.
> (as implemented in include/asm-i386/pgtable.h) ?
I don't think that needs it either.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Satya <satyakiran@gmail.com>
Cc: linuxppc-dev@ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: pte_offset_map for ppc assumes HIGHPTE
Date: Thu, 26 Jul 2007 01:18:48 +0200 [thread overview]
Message-ID: <jewswodqcn.fsf@sykes.suse.de> (raw)
In-Reply-To: <acbcf3840707251516w301f834cj5f6a81a494d359ed@mail.gmail.com> (Satya's message of "Wed\, 25 Jul 2007 17\:16\:01 -0500")
Satya <satyakiran@gmail.com> writes:
> hello,
> The implementation of pte_offset_map() for ppc assumes that PTEs are
> kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of
> pte_offset_map() as follows (include/asm-ppc/pgtable.h):
>
> #define pte_offset_map(dir, addr) \
> ((pte_t *) kmap_atomic(pmd_page(*(dir)), KM_PTE0) + pte_index(addr))
>
> Shouldn't this be made conditional according to CONFIG_HIGHPTE is
> defined or not
kmap_atomic is always defined with or without CONFIG_HIGHPTE.
> (as implemented in include/asm-i386/pgtable.h) ?
I don't think that needs it either.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstrasse 5, 90409 Nurnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-25 23:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 22:16 pte_offset_map for ppc assumes HIGHPTE Satya
2007-07-25 22:16 ` Satya
2007-07-25 23:10 ` Benjamin Herrenschmidt
2007-07-25 23:10 ` Benjamin Herrenschmidt
2007-07-25 23:10 ` Benjamin Herrenschmidt
2007-07-25 23:18 ` Andreas Schwab [this message]
2007-07-25 23:18 ` Andreas Schwab
2007-07-25 23:18 ` Andreas Schwab
2007-07-25 23:22 ` Benjamin Herrenschmidt
2007-07-25 23:22 ` Benjamin Herrenschmidt
2007-07-25 23:22 ` Benjamin Herrenschmidt
2007-07-25 23:30 ` Dave McCracken
2007-07-25 23:30 ` Dave McCracken
2007-07-25 23:30 ` Dave McCracken
2007-07-26 0:18 ` Benjamin Herrenschmidt
2007-07-26 0:18 ` Benjamin Herrenschmidt
2007-07-26 0:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jewswodqcn.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=satyakiran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.