From: Valentin Schneider <valentin.schneider@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
kernel-team@android.com, Quentin Perret <qperret@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, morten.rasmussen@arm.com,
Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] sched/topology: Don't enable EAS on SMT systems
Date: Thu, 27 Feb 2020 16:42:55 +0000 [thread overview]
Message-ID: <jhjftewvv5c.mognet@arm.com> (raw)
In-Reply-To: <7ce12aa2-1925-f991-a85f-5bd81ba668fb@arm.com>
On Thu, Feb 27 2020, Dietmar Eggemann wrote:
>>> + /* EAS definitely does *not* handle SMT */
>>> + if (sched_smt_active())
>
> Can you add a pr_warn() and use the current comment as the warning
> message? Since we have one for !Asym CPU capacity and !schedutil.
>
>>> + goto free;
>>> +
>
> [...]
>
> There is this 'EAS can be used ...' list of currently 4 items in the
> build_perf_domains() function header. You could include 'X. No SMT
> support' there.
> ;-)
Right, the rst doc says "EAS on SMT is not supported" but I think that can
be interpreted as "EAS on !asym SMT". I'll add the warning and update the
comment.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Quentin Perret <qperret@google.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
morten.rasmussen@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
kernel-team@android.com
Subject: Re: [PATCH 1/2] sched/topology: Don't enable EAS on SMT systems
Date: Thu, 27 Feb 2020 16:42:55 +0000 [thread overview]
Message-ID: <jhjftewvv5c.mognet@arm.com> (raw)
In-Reply-To: <7ce12aa2-1925-f991-a85f-5bd81ba668fb@arm.com>
On Thu, Feb 27 2020, Dietmar Eggemann wrote:
>>> + /* EAS definitely does *not* handle SMT */
>>> + if (sched_smt_active())
>
> Can you add a pr_warn() and use the current comment as the warning
> message? Since we have one for !Asym CPU capacity and !schedutil.
>
>>> + goto free;
>>> +
>
> [...]
>
> There is this 'EAS can be used ...' list of currently 4 items in the
> build_perf_domains() function header. You could include 'X. No SMT
> support' there.
> ;-)
Right, the rst doc says "EAS on SMT is not supported" but I think that can
be interpreted as "EAS on !asym SMT". I'll add the warning and update the
comment.
next prev parent reply other threads:[~2020-02-27 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 16:41 [PATCH 0/2] sched, arm64: enable CONFIG_SCHED_SMT for arm64 Valentin Schneider
2020-02-26 16:41 ` Valentin Schneider
2020-02-26 16:41 ` [PATCH 1/2] sched/topology: Don't enable EAS on SMT systems Valentin Schneider
2020-02-26 16:41 ` Valentin Schneider
2020-02-27 13:00 ` Quentin Perret
2020-02-27 13:00 ` Quentin Perret
2020-02-27 16:28 ` Dietmar Eggemann
2020-02-27 16:28 ` Dietmar Eggemann
2020-02-27 16:42 ` Valentin Schneider [this message]
2020-02-27 16:42 ` Valentin Schneider
2020-02-26 16:41 ` [PATCH 2/2] arm64: defconfig: enable CONFIG_SCHED_SMT Valentin Schneider
2020-02-26 16:41 ` Valentin Schneider
2020-02-27 16:28 ` Dietmar Eggemann
2020-02-27 16:37 ` Valentin Schneider
2020-02-27 16:32 ` [PATCH 0/2] sched, arm64: enable CONFIG_SCHED_SMT for arm64 Dietmar Eggemann
2020-02-27 16:32 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjftewvv5c.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.