* [meta-oe][PATCH 1/2][resend] giflib: don't link against libx11, don't depend on libsm @ 2012-03-01 12:20 Andreas Oberritter 2012-03-01 12:20 ` [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 Andreas Oberritter 0 siblings, 1 reply; 4+ messages in thread From: Andreas Oberritter @ 2012-03-01 12:20 UTC (permalink / raw) To: openembedded-devel libsm wasn't used unless libx11 was built before giflib. Therefore drop the dependency on libsm and disable x11 unconditionally like Debian does. Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb b/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb index bd7b495..e1a0777 100644 --- a/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +++ b/meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb @@ -2,13 +2,13 @@ DESCRIPTION = "shared library for GIF images" SECTION = "libs" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a" -PR = "r2" +PR = "r3" SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2" inherit autotools -DEPENDS = "libsm" +EXTRA_OECONF = "--disable-x11" PACKAGES += "${PN}-utils" FILES_${PN} = "${libdir}/libgif.so.*" -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 2012-03-01 12:20 [meta-oe][PATCH 1/2][resend] giflib: don't link against libx11, don't depend on libsm Andreas Oberritter @ 2012-03-01 12:20 ` Andreas Oberritter 2012-03-02 8:17 ` Koen Kooi 0 siblings, 1 reply; 4+ messages in thread From: Andreas Oberritter @ 2012-03-01 12:20 UTC (permalink / raw) To: openembedded-devel * consolekit fails to build without x11, so disable creation of udev-consolekit, if x11 is unavailable. Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- meta-oe/recipes-core/udev/udev_173.bb | 2 +- meta-oe/recipes-core/udev/udev_175.bb | 2 +- meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/meta-oe/recipes-core/udev/udev_173.bb b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..cbbe910 100644 --- a/meta-oe/recipes-core/udev/udev_173.bb +++ b/meta-oe/recipes-core/udev/udev_173.bb @@ -59,7 +59,7 @@ do_configure_prepend() { INITSCRIPT_NAME = "udev" INITSCRIPT_PARAMS = "start 04 S ." -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit" +PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)}" FILES_${PN}-systemd = "${base_libdir}/systemd" RDEPENDS_${PN}-systemd += "udev" diff --git a/meta-oe/recipes-core/udev/udev_175.bb b/meta-oe/recipes-core/udev/udev_175.bb index b6484d9..6560b5d 100644 --- a/meta-oe/recipes-core/udev/udev_175.bb +++ b/meta-oe/recipes-core/udev/udev_175.bb @@ -55,7 +55,7 @@ do_configure_prepend() { cp ${WORKDIR}/gtk-doc.make ${S} } -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit" +PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)}" FILES_${PN}-systemd = "${base_libdir}/systemd" RDEPENDS_${PN}-systemd += "udev" diff --git a/meta-oe/recipes-core/udev/udev_181.bb b/meta-oe/recipes-core/udev/udev_181.bb index 1e0a02a..99b66b1 100644 --- a/meta-oe/recipes-core/udev/udev_181.bb +++ b/meta-oe/recipes-core/udev/udev_181.bb @@ -54,7 +54,7 @@ do_configure_prepend() { cp ${WORKDIR}/gtk-doc.make ${S} } -PACKAGES =+ "${PN}-systemd libudev libgudev udev-consolekit udev-utils" +PACKAGES =+ "${PN}-systemd libudev libgudev ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)} udev-utils" FILES_${PN}-systemd = "${base_libdir}/systemd" RDEPENDS_${PN}-systemd += "udev" -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 2012-03-01 12:20 ` [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 Andreas Oberritter @ 2012-03-02 8:17 ` Koen Kooi 2012-03-02 14:49 ` Andreas Oberritter 0 siblings, 1 reply; 4+ messages in thread From: Koen Kooi @ 2012-03-02 8:17 UTC (permalink / raw) To: openembedded-devel -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 01-03-12 13:20, Andreas Oberritter schreef: > * consolekit fails to build without x11, so disable creation of > udev-consolekit, if x11 is unavailable. > > Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- > meta-oe/recipes-core/udev/udev_173.bb | 2 +- > meta-oe/recipes-core/udev/udev_175.bb | 2 +- > meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3 > insertions(+), 3 deletions(-) > > diff --git a/meta-oe/recipes-core/udev/udev_173.bb > b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..cbbe910 100644 --- > a/meta-oe/recipes-core/udev/udev_173.bb +++ > b/meta-oe/recipes-core/udev/udev_173.bb @@ -59,7 +59,7 @@ > do_configure_prepend() { INITSCRIPT_NAME = "udev" INITSCRIPT_PARAMS = > "start 04 S ." > > -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit" > +PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils > ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)}" What does this actually accomplish? If the package is empty it won't get generated anyway and if it isn't empty you just introduced a QA error. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk9QggsACgkQMkyGM64RGpE5IACgh7qgjWEzWhgUWGBMxCjM86GY lD4AnRj/2+bgRdsJAt/PJ0Xm0jmK+rVb =9tpQ -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 2012-03-02 8:17 ` Koen Kooi @ 2012-03-02 14:49 ` Andreas Oberritter 0 siblings, 0 replies; 4+ messages in thread From: Andreas Oberritter @ 2012-03-02 14:49 UTC (permalink / raw) To: openembedded-devel; +Cc: Koen Kooi On 02.03.2012 09:17, Koen Kooi wrote: > Op 01-03-12 13:20, Andreas Oberritter schreef: >> * consolekit fails to build without x11, so disable creation of >> udev-consolekit, if x11 is unavailable. > >> Signed-off-by: Andreas Oberritter <obi@opendreambox.org> --- >> meta-oe/recipes-core/udev/udev_173.bb | 2 +- >> meta-oe/recipes-core/udev/udev_175.bb | 2 +- >> meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3 >> insertions(+), 3 deletions(-) > >> diff --git a/meta-oe/recipes-core/udev/udev_173.bb >> b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..cbbe910 100644 --- >> a/meta-oe/recipes-core/udev/udev_173.bb +++ >> b/meta-oe/recipes-core/udev/udev_173.bb @@ -59,7 +59,7 @@ >> do_configure_prepend() { INITSCRIPT_NAME = "udev" INITSCRIPT_PARAMS = >> "start 04 S ." > >> -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit" >> +PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils >> ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)}" > > What does this actually accomplish? If the package is empty it won't get > generated anyway and if it isn't empty you just introduced a QA error. The recipe contains: RDEPENDS_${PN}-consolekit += "consolekit" Therefore, consolekit gets built when building udev, but fails: ERROR: Nothing RPROVIDES 'consolekit' (but .../meta-oe/recipes-core/udev/udev_181.bb RDEPENDS on or otherwise requires it) ERROR: consolekit was skipped: 'x11' not in DISTRO_FEATURES NOTE: Runtime target 'consolekit' is unbuildable, removing... Missing or unbuildable dependency chain was: ['consolekit'] ERROR: Required build target 'udev' has no buildable providers. Missing or unbuildable dependency chain was: ['udev', 'consolekit'] That's what the patch is addressing. Which alternative would you suggest instead? To omit the runtime dependency? About the QA error, if this is the error you're referring to, then the warning is not very helpful: WARNING: For recipe udev, the following files/directories were installed but not shipped in any package: WARNING: /usr/sbin Regards, Andreas ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-02 14:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-01 12:20 [meta-oe][PATCH 1/2][resend] giflib: don't link against libx11, don't depend on libsm Andreas Oberritter 2012-03-01 12:20 ` [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 Andreas Oberritter 2012-03-02 8:17 ` Koen Kooi 2012-03-02 14:49 ` Andreas Oberritter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.