From: Robbie Harwood <rharwood@redhat.com>
To: Glenn Washburn <development@efficientek.com>,
grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Glenn Washburn <development@efficientek.com>
Subject: Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set
Date: Fri, 25 Mar 2022 11:54:59 -0400 [thread overview]
Message-ID: <jlg35j6gh7w.fsf@redhat.com> (raw)
In-Reply-To: <20220324223116.3222258-1-development@efficientek.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Glenn Washburn <development@efficientek.com> writes:
> Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS
> was defaulted to "" early in configure to prevent this. Apparently something
> changed in autoconf and now AC_USE_SYSTEM_EXTENSIONS, which is before the
> default setting of CFLAGS, will pull in this check. Move the default
> setting of CFLAGS to before this so that if will see CFLAGS as set and not
> give it a default.
This is a result of ad9ccf660013c208077b1e983d6c824df25ed1cf
("configure: Fix various new autotools warnings"), which hoisted
AC_USE_SYSTEM_EXTENSIONS to avoid a new warning (slightly too far, it
seems).
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Be well,
--Robbie
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-03-25 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 22:31 [PATCH] configure: Fix default -O2 being added when CFLAGS not set Glenn Washburn
2022-03-25 6:53 ` Paul Menzel
2022-03-28 16:14 ` Glenn Washburn
2022-03-25 15:54 ` Robbie Harwood [this message]
2022-03-28 15:53 ` Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jlg35j6gh7w.fsf@redhat.com \
--to=rharwood@redhat.com \
--cc=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.