Re: [PATCH v4 1/1] Add support for grub-emu to kexec Linux menu entries

[Robbie Harwood <rharwood@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Daniel Kiper <dkiper@net-space.pl> writes:

> On Tue, Oct 04, 2022 at 03:16:48PM -0400, Robbie Harwood wrote:
>
>> +  return rc;
>> +}
>> +
>> +static grub_err_t
>> +grub_linux_unload (void)
>> +{
>> +  grub_dl_unref (my_mod);
>
> I understand that this marks this module as not in use. Right? If yes
> please add a comment before grub_dl_unref() call what exactly happens
> here and why. It took me a while to understand why it is
> needed. Please do the same below for all grub_dl_ref() and
> grub_dl_unref() calls.

I expect it's modeled after the other linux.c - e.g.,
grub-core/loader/i386/linux.c has an almost identical
grub_linux_unload() function.

Be well,
--Robbie

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]