All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robbie Harwood <rharwood@redhat.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Daniel Axtens <dja@axtens.net>,
	grub-devel@gnu.org, darren.kenny@oracle.com, ps@pks.im,
	phcoder@gmail.com
Subject: Re: [PATCH] Drop gnulib fix-base64.patch
Date: Wed, 24 Nov 2021 09:36:14 -0500	[thread overview]
Message-ID: <jlgczmp39k1.fsf@redhat.com> (raw)
In-Reply-To: <20211123172038.jnzcb23yq3llaefy@tomti.i.net-space.pl>

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Daniel Kiper <dkiper@net-space.pl> writes:

> CC-ing Daren, Patrick and Vladimir...
>
> When I started looking at this issue I realized we have bigger problem
> here than lack of _GL_ATTRIBUTE_CONST definition. In general all _GL_*
> constants land in config-util.h.in and finally in config-util.h. It
> does not make a lot of sense because config-util.h is not included
> when you build GRUB core. Instead it is included when you build GRUB
> utils. Huh!  AFAICT this means the gnulib is deprived of all its
> specific constants.  I am not sure how it worked at all in so
> far. Anyway, I think we have to fix it properly.
>
> Robbie, may I ask you to talk to gnulib folks and ask them how we
> should solve this problem? Please CC all folks CC-ed in this email.

I'm not opposed to getting gnulib's opinion, but don't we already know
what they suggest from
https://lists.gnu.org/archive/html/bug-gnulib/2021-11/msg00009.html
(i.e., run configure twice)?

(Though if other folks on CC want to provide more input on
https://lists.gnu.org/archive/html/bug-gnulib/2021-11/msg00028.html that
would be helpful.)

Be well,
--Robbie

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-11-24 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 19:22 [PATCH] Drop gnulib fix-base64.patch Robbie Harwood
2021-11-03 11:59 ` Darren Kenny
2021-11-14  9:36 ` Patrick Steinhardt
2021-11-23 15:33 ` Daniel Axtens
2021-11-23 16:08   ` Robbie Harwood
2021-11-23 17:20     ` Daniel Kiper
2021-11-24 14:36       ` Robbie Harwood [this message]
2021-11-25 17:09         ` Daniel Kiper
2021-11-29 23:21           ` Robbie Harwood
2021-11-30 16:33             ` Daniel Kiper
2021-12-07 20:34               ` Robbie Harwood
2021-12-09 14:46                 ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jlgczmp39k1.fsf@redhat.com \
    --to=rharwood@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=dja@axtens.net \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.