Re: [PATCH] Drop gnulib fix-base64.patch

[Robbie Harwood <rharwood@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Daniel Axtens <dja@axtens.net> writes:

> Robbie Harwood <rharwood@redhat.com> writes:
>
>> +/* For gnulib's base64 code. */
>> +#define _GL_ATTRIBUTE_CONST /* empty */
>
> Do we support any compiler so old or configuration so weird that we
> can't simply use 'const' here?

Unfortunately it's not quite that simple.  _GL_ATTRIBUTE_CONST actually
gates turning on `__attribute ((__const__))`, which if memory serves is
a GCC extension.  I don't know what the support matrix on grub is, but
based on the original patch there was a need to support non-gcc-likes.
Would be fine with changing that, though.

(Personally, I think it should be obvious to a reasonable compiler that
isbase64() is purely arithmetic.  However, gnulib upstream did not like
my proposal to drop the attribute marker, so we're stuck with it.)

Be well,
--Robbie

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]