From: Robbie Harwood <rharwood@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, grub-devel@gnu.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions
Date: Thu, 26 May 2022 17:07:11 -0400 [thread overview]
Message-ID: <jlgsfow2ebk.fsf@redhat.com> (raw)
In-Reply-To: <20220520143741.217690-6-mathieu.desnoyers@efficios.com>
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
> There are no users left of version_find_latest(), version_test_gt(), and
> version_test_numeric(). Remove those unused helper functions. Using
> those helper functions is what caused the quadratic sorting performance
> issues in the first place, so removing them is a net win.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Be well,
--Robbie
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-05-26 21:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 14:37 [RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items Mathieu Desnoyers
2022-05-20 14:37 ` [RFC PATCH v3 1/5] grub-mkconfig linux: " Mathieu Desnoyers
2022-05-26 15:13 ` Daniel Kiper
2022-05-26 18:34 ` Mathieu Desnoyers
2022-06-08 18:10 ` Daniel Kiper
2022-05-20 14:37 ` [RFC PATCH v3 2/5] grub-mkconfig linux_xen: " Mathieu Desnoyers
2022-05-20 14:37 ` [RFC PATCH v3 3/5] grub-mkconfig hurd: " Mathieu Desnoyers
2022-05-20 14:37 ` [RFC PATCH v3 4/5] grub-mkconfig kfreebsd: " Mathieu Desnoyers
2022-05-20 14:37 ` [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions Mathieu Desnoyers
2022-05-26 21:07 ` Robbie Harwood [this message]
2022-05-27 6:07 ` Michael Chang
2022-05-27 14:56 ` Robbie Harwood
2022-05-27 21:45 ` Daniel Kiper
2022-05-30 13:31 ` Mathieu Desnoyers
2022-05-20 16:08 ` [RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items Mathieu Desnoyers
2022-05-26 15:24 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jlgsfow2ebk.fsf@redhat.com \
--to=rharwood@redhat.com \
--cc=grub-devel@gnu.org \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.