From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-mm@kvack.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Bad use of highmem with buffer_migrate_page?
Date: Thu, 5 Jul 2012 13:56:43 +0000 (UTC) [thread overview]
Message-ID: <jt46eq$lq0$4@dough.gmane.org> (raw)
In-Reply-To: 20120705104520.GA6773@latitude
On Thu, 05 Jul 2012 at 10:45 GMT, Rabin Vincent <rabin@rab.in> wrote:
> 8<----
> From 8a94126eb3aa2824866405fb78bb0b8316f8fd00 Mon Sep 17 00:00:00 2001
> From: Rabin Vincent <rabin@rab.in>
> Date: Thu, 5 Jul 2012 15:52:23 +0530
> Subject: [PATCH] mm: cma: don't replace lowmem pages with highmem
>
> The filesystem layer expects pages in the block device's mapping to not
> be in highmem (the mapping's gfp mask is set in bdget()), but CMA can
> currently replace lowmem pages with highmem pages, leading to crashes in
> filesystem code such as the one below:
>
...
> Fix this by replacing only highmem pages with highmem.
>
Looks good to me too,
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: xiyou.wangcong@gmail.com (Cong Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: Bad use of highmem with buffer_migrate_page?
Date: Thu, 5 Jul 2012 13:56:43 +0000 (UTC) [thread overview]
Message-ID: <jt46eq$lq0$4@dough.gmane.org> (raw)
In-Reply-To: 20120705104520.GA6773@latitude
On Thu, 05 Jul 2012 at 10:45 GMT, Rabin Vincent <rabin@rab.in> wrote:
> 8<----
> From 8a94126eb3aa2824866405fb78bb0b8316f8fd00 Mon Sep 17 00:00:00 2001
> From: Rabin Vincent <rabin@rab.in>
> Date: Thu, 5 Jul 2012 15:52:23 +0530
> Subject: [PATCH] mm: cma: don't replace lowmem pages with highmem
>
> The filesystem layer expects pages in the block device's mapping to not
> be in highmem (the mapping's gfp mask is set in bdget()), but CMA can
> currently replace lowmem pages with highmem pages, leading to crashes in
> filesystem code such as the one below:
>
...
> Fix this by replacing only highmem pages with highmem.
>
Looks good to me too,
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
next prev parent reply other threads:[~2012-07-05 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 20:07 Bad use of highmem with buffer_migrate_page? Laura Abbott
2012-05-10 20:07 ` Laura Abbott
2012-05-11 8:30 ` Marek Szyprowski
2012-05-11 8:30 ` Marek Szyprowski
2012-05-11 21:51 ` Laura Abbott
2012-05-11 21:51 ` Laura Abbott
2012-07-05 9:28 ` Rabin Vincent
2012-07-05 9:28 ` Rabin Vincent
2012-07-05 9:28 ` Rabin Vincent
2012-07-05 10:05 ` Marek Szyprowski
2012-07-05 10:05 ` Marek Szyprowski
2012-07-05 10:05 ` Marek Szyprowski
2012-07-05 10:45 ` Rabin Vincent
2012-07-05 10:45 ` Rabin Vincent
2012-07-05 10:45 ` Rabin Vincent
2012-07-05 10:45 ` Rabin Vincent
2012-07-05 13:56 ` Cong Wang [this message]
2012-07-05 13:56 ` Cong Wang
2012-07-05 19:21 ` Michał Nazarewicz
2012-07-05 19:21 ` Michał Nazarewicz
2012-07-05 19:21 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jt46eq$lq0$4@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.