* [Cocci] a small nuisance report
@ 2018-04-29 13:14 Robert Larice
2018-04-29 13:29 ` Julia Lawall
2018-04-29 17:56 ` Julia Lawall
0 siblings, 2 replies; 6+ messages in thread
From: Robert Larice @ 2018-04-29 13:14 UTC (permalink / raw)
To: cocci
Hello,
attached is a small example which
injects a statement and a comment.
It works well, but does'nt do exactly as wanted.
I get :
+ j /* comments are overrated */
+ -= 3;
The comment popped up within the expression instead
of in front of it.
no bug, but uggly.
Regards,
Robert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ex2.c
Type: text/x-csrc
Size: 87 bytes
Desc: not available
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20180429/760a0ab8/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ex2.cocci
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20180429/760a0ab8/attachment.ksh>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Cocci] a small nuisance report
2018-04-29 13:14 [Cocci] a small nuisance report Robert Larice
@ 2018-04-29 13:29 ` Julia Lawall
2018-04-29 17:56 ` Julia Lawall
1 sibling, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2018-04-29 13:29 UTC (permalink / raw)
To: cocci
On Sun, 29 Apr 2018, Robert Larice wrote:
> Hello,
>
> attached is a small example which
> injects a statement and a comment.
>
> It works well, but does'nt do exactly as wanted.
>
> I get :
>
> + j /* comments are overrated */
> + -= 3;
>
> The comment popped up within the expression instead
> of in front of it.
> no bug, but uggly.
Indeed, it should not be there.
julia
>
> Regards,
> Robert
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cocci] a small nuisance report
2018-04-29 13:14 [Cocci] a small nuisance report Robert Larice
2018-04-29 13:29 ` Julia Lawall
@ 2018-04-29 17:56 ` Julia Lawall
2018-04-29 18:10 ` Robert Larice
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2018-04-29 17:56 UTC (permalink / raw)
To: cocci
On Sun, 29 Apr 2018, Robert Larice wrote:
> Hello,
>
> attached is a small example which
> injects a statement and a comment.
>
> It works well, but does'nt do exactly as wanted.
>
> I get :
>
> + j /* comments are overrated */
> + -= 3;
>
> The comment popped up within the expression instead
> of in front of it.
> no bug, but uggly.
This problem is solve in the github version of Coccinelle. The problem
was because j was declared as a symbol.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cocci] a small nuisance report
2018-04-29 17:56 ` Julia Lawall
@ 2018-04-29 18:10 ` Robert Larice
2018-04-29 18:30 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Robert Larice @ 2018-04-29 18:10 UTC (permalink / raw)
To: cocci
Julia Lawall <julia.lawall@lip6.fr> writes:
> On Sun, 29 Apr 2018, Robert Larice wrote:
>
>> Hello,
>>
>> attached is a small example which
>> injects a statement and a comment.
>>
>> It works well, but does'nt do exactly as wanted.
>>
>> I get :
>>
>> + j /* comments are overrated */
>> + -= 3;
>>
>> The comment popped up within the expression instead
>> of in front of it.
>> no bug, but uggly.
>
> This problem is solve in the github version of Coccinelle. The problem
> was because j was declared as a symbol.
>
> julia
Thank You,
so I could work around by simply using an "identifier"
perhaps augmented with a regexp match.
Best Regards,
Robert
^ permalink raw reply [flat|nested] 6+ messages in thread* [Cocci] a small nuisance report
2018-04-29 18:10 ` Robert Larice
@ 2018-04-29 18:30 ` Julia Lawall
2018-04-29 19:10 ` Robert Larice
0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2018-04-29 18:30 UTC (permalink / raw)
To: cocci
On Sun, 29 Apr 2018, Robert Larice wrote:
> Julia Lawall <julia.lawall@lip6.fr> writes:
>
> > On Sun, 29 Apr 2018, Robert Larice wrote:
> >
> >> Hello,
> >>
> >> attached is a small example which
> >> injects a statement and a comment.
> >>
> >> It works well, but does'nt do exactly as wanted.
> >>
> >> I get :
> >>
> >> + j /* comments are overrated */
> >> + -= 3;
> >>
> >> The comment popped up within the expression instead
> >> of in front of it.
> >> no bug, but uggly.
> >
> > This problem is solve in the github version of Coccinelle. The problem
> > was because j was declared as a symbol.
> >
> > julia
>
> Thank You,
>
> so I could work around by simply using an "identifier"
> perhaps augmented with a regexp match.
No, just pull from github and recompile.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cocci] a small nuisance report
2018-04-29 18:30 ` Julia Lawall
@ 2018-04-29 19:10 ` Robert Larice
0 siblings, 0 replies; 6+ messages in thread
From: Robert Larice @ 2018-04-29 19:10 UTC (permalink / raw)
To: cocci
Julia Lawall <julia.lawall@lip6.fr> writes:
> On Sun, 29 Apr 2018, Robert Larice wrote:
>
>> Julia Lawall <julia.lawall@lip6.fr> writes:
>>
>> > On Sun, 29 Apr 2018, Robert Larice wrote:
>> >
>> >> Hello,
>> >>
>> >> attached is a small example which
>> >> injects a statement and a comment.
>> >>
>> >> It works well, but does'nt do exactly as wanted.
>> >>
>> >> I get :
>> >>
>> >> + j /* comments are overrated */
>> >> + -= 3;
>> >>
>> >> The comment popped up within the expression instead
>> >> of in front of it.
>> >> no bug, but uggly.
>> >
>> > This problem is solve in the github version of Coccinelle. The problem
>> > was because j was declared as a symbol.
>> >
>> > julia
>>
>> Thank You,
>>
>> so I could work around by simply using an "identifier"
>> perhaps augmented with a regexp match.
>
> No, just pull from github and recompile.
>
> julia
just did, and it just works,
Thanks,
Robert
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-29 19:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-29 13:14 [Cocci] a small nuisance report Robert Larice
2018-04-29 13:29 ` Julia Lawall
2018-04-29 17:56 ` Julia Lawall
2018-04-29 18:10 ` Robert Larice
2018-04-29 18:30 ` Julia Lawall
2018-04-29 19:10 ` Robert Larice
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.