[Dracut PATCH] usrmount: Fix miss-detection of btrfs subvolumes.

[Dracut PATCH] usrmount: Fix miss-detection of btrfs subvolumes.

[Colin Guthrie]

This causes the root FS options to be incorrectly applied to to /usr
In some cases this can cause boot failure e.g. due to and XFS /usr
not supporting the 'acl' option from the ext4 root FS.

https://bugs.mageia.org/show_bug.cgi?id=9884
---
 modules.d/98usrmount/mount-usr.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules.d/98usrmount/mount-usr.sh b/modules.d/98usrmount/mount-usr.sh
index a4a66ae..de7dcc2 100755
--- a/modules.d/98usrmount/mount-usr.sh
+++ b/modules.d/98usrmount/mount-usr.sh
@@ -61,14 +61,14 @@ mount_usr()
                 LABEL=*)
                     _dev="$(echo $_dev | sed 's,/,\\x2f,g')"
                     _dev="/dev/disk/by-label/${_dev#LABEL=}"
-		    ;;
+                    ;;
                 UUID=*)
                     _dev="${_dev#block:}"
                     _dev="/dev/disk/by-uuid/${_dev#UUID=}"
                     ;;
             esac
             if strstr "$_opts" "subvol=" && \
-                [ "${root#block:}" -ef $_dev ]
+                [ "${root#block:}" -ef $_dev ] && \
                 [ -n "$rflags" ]; then
                 # for btrfs subvolumes we have to mount /usr with the same rflags
                 rflags=$(filtersubvol "$rflags")
-- 
1.8.1.5

Re: [Dracut PATCH] usrmount: Fix miss-detection of btrfs subvolumes.

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 03/05/13 17:16 did gyre and gimble:
> This causes the root FS options to be incorrectly applied to to /usr
> In some cases this can cause boot failure e.g. due to and XFS /usr
> not supporting the 'acl' option from the ext4 root FS.
> 
> https://bugs.mageia.org/show_bug.cgi?id=9884


For the sake of history, committed as
d57b8833c43d297004d8393d8e54a2ab2655a899

Thanks :)

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/