[meta-networking][PATCH] crda: fix udev rule

[meta-networking][PATCH] crda: fix udev rule

[Javier Viguera]

The SBINDIR variable in makefile's install rule needs to have a trailing
slash so the path to the 'crda' binary in the udev rule is correct.

Otherwise the udev rule has a wrong path:

KERNEL=="regulatory*", ACTION=="change", SUBSYSTEM=="platform", RUN+="/usr/sbincrda"

and at runtime udev complains:

failed to execute '/usr/sbincrda'

when a regulatory domain event is triggered.

Signed-off-by: Javier Viguera <javier.viguera@digi.com>
---
 meta-networking/recipes-connectivity/crda/crda_1.1.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
index bee3e826d9a8..0bb899860bc4 100644
--- a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
+++ b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
@@ -24,7 +24,7 @@ do_compile() {
 }
 
 do_install() {
-    oe_runmake SBINDIR=${sbindir} install
+    oe_runmake SBINDIR=${sbindir}/ install
 
     install -d ${D}${libdir}/crda/
 

Re: [meta-networking][PATCH] crda: fix udev rule

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Javier Viguera schreef op 12-03-14 16:27:
> The SBINDIR variable in makefile's install rule needs to have a trailing 
> slash so the path to the 'crda' binary in the udev rule is correct.
> 
> Otherwise the udev rule has a wrong path:
> 
> KERNEL=="regulatory*", ACTION=="change", SUBSYSTEM=="platform",
> RUN+="/usr/sbincrda"
> 
> and at runtime udev complains:
> 
> failed to execute '/usr/sbincrda'
> 
> when a regulatory domain event is triggered.

That explains a lot :)

Acked-by: Koen Kooi <koen@dominion.thruhere.net>

> 
> Signed-off-by: Javier Viguera <javier.viguera@digi.com> --- 
> meta-networking/recipes-connectivity/crda/crda_1.1.3.bb | 2 +- 1 file
> changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
> b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb index
> bee3e826d9a8..0bb899860bc4 100644 ---
> a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb +++
> b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb @@ -24,7 +24,7
> @@ do_compile() { }
> 
> do_install() { -    oe_runmake SBINDIR=${sbindir} install +    oe_runmake
> SBINDIR=${sbindir}/ install
> 
> install -d ${D}${libdir}/crda/
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTIW3DMkyGM64RGpERAocGAKCiI+ynx1m6Il+BsO6/MzbF9OkHigCfbzN6
HaDitNRN4Xl7pLk1AAlBG5E=
=G2ib
-----END PGP SIGNATURE-----

Re: [meta-networking] crda: fix udev rule

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Merged, thanks.
-J.

[[meta-networking] crda: fix udev rule] On 14.03.12 (Wed 16:27) Javier Viguera wrote:

> The SBINDIR variable in makefile's install rule needs to have a trailing
> slash so the path to the 'crda' binary in the udev rule is correct.
> 
> Otherwise the udev rule has a wrong path:
> 
> KERNEL=="regulatory*", ACTION=="change", SUBSYSTEM=="platform", RUN+="/usr/sbincrda"
> 
> and at runtime udev complains:
> 
> failed to execute '/usr/sbincrda'
> 
> when a regulatory domain event is triggered.
> 
> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
> Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> 
> ---
> meta-networking/recipes-connectivity/crda/crda_1.1.3.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
> index bee3e826d9a8..0bb899860bc4 100644
> --- a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
> +++ b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
> @@ -24,7 +24,7 @@ do_compile() {
>  }
>  
>  do_install() {
> -    oe_runmake SBINDIR=${sbindir} install
> +    oe_runmake SBINDIR=${sbindir}/ install
>  
>      install -d ${D}${libdir}/crda/
>  

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]