[meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Lauren Post]

Replace SRC_URI with new location, md5sum and new name since previous download
will not work.  Without this fix cpuburn-neon has a broken build.

Signed-off-by: Lauren Post <lauren.post@freescale.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 ...n-neon_20120610.bb => cpuburn-neon_20140626.bb} |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
 rename meta-oe/recipes-benchmark/cpuburn/{cpuburn-neon_20120610.bb => cpuburn-neon_20140626.bb} (72%)

diff --git a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb
similarity index 72%
rename from meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb
rename to meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb
index 8ec5e95..ed1f1ee 100644
--- a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb
+++ b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb
@@ -8,17 +8,18 @@ DL_DIR_append = "/${PN}-${PV}"
 COMPATIBLE_MACHINE = "(${@bb.utils.contains("TUNE_FEATURES", "neon", "${MACHINE}", "Invalid!", d)})"
 
 SRC_URI = "http://hardwarebug.org/files/burn.S;name=mru \
-           http://github.com/downloads/ssvb/ssvb.github.com/ssvb-cpuburn-a8.S;name=ssvb"
+           https://github.com/ssvb/cpuburn-arm/raw/master/cpuburn-a8.S;name=ssvb"
+
 SRC_URI[mru.md5sum] = "823abc72c2cd448e87df9bc5355a4456"
 SRC_URI[mru.sha256sum] = "01d9fc04f83740c513c25401dcc89c11b2a5a6013e70bfca42b7b02129f88cd2"
-SRC_URI[ssvb.md5sum] = "0acc570d943c41c7f8602b9ff6fa111d"
-SRC_URI[ssvb.sha256sum] = "bfddd3226a499ffdf71bb58c05ccdc6dac5bb2c2c3bdb10ac610ee0b60aac087"
+SRC_URI[ssvb.md5sum] = "ba0ef2939a3b3b487523448c67544e94"
+SRC_URI[ssvb.sha256sum] = "ce42ebdc71c876a33d9f7534355ef76cefa0d00ddb19ad69cf05a266c861d08d"
 
 S = "${WORKDIR}"
 
 do_compile() {
     ${CC} ${CFLAGS} ${LDFLAGS} burn.S -o burn
-    ${CC} ${CFLAGS} ${LDFLAGS} ssvb-cpuburn-a8.S -o burn-neona8
+    ${CC} ${CFLAGS} ${LDFLAGS} cpuburn-a8.S -o burn-neona8
 }
 
 do_install() {
-- 
1.7.9.5

Re: [meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lauren Post schreef op 26-06-14 16:37:
> Replace SRC_URI with new location, md5sum and new name since previous
> download will not work.  Without this fix cpuburn-neon has a broken
> build.

Why not make the recipe clone the git repo?


> 
> Signed-off-by: Lauren Post <lauren.post@freescale.com> Signed-off-by:
> Otavio Salvador <otavio@ossystems.com.br> --- ...n-neon_20120610.bb =>
> cpuburn-neon_20140626.bb} |    9 +++++---- 1 file changed, 5
> insertions(+), 4 deletions(-) rename
> meta-oe/recipes-benchmark/cpuburn/{cpuburn-neon_20120610.bb =>
> cpuburn-neon_20140626.bb} (72%)
> 
> diff --git a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb
> b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb similarity
> index 72% rename from
> meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb rename to
> meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb index
> 8ec5e95..ed1f1ee 100644 ---
> a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20120610.bb +++
> b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon_20140626.bb @@ -8,17
> +8,18 @@ DL_DIR_append = "/${PN}-${PV}" COMPATIBLE_MACHINE =
> "(${@bb.utils.contains("TUNE_FEATURES", "neon", "${MACHINE}", "Invalid!",
> d)})"
> 
> SRC_URI = "http://hardwarebug.org/files/burn.S;name=mru \ -
> http://github.com/downloads/ssvb/ssvb.github.com/ssvb-cpuburn-a8.S;name=ssvb"
>
> 
+           https://github.com/ssvb/cpuburn-arm/raw/master/cpuburn-a8.S;name=ssvb"
> + SRC_URI[mru.md5sum] = "823abc72c2cd448e87df9bc5355a4456" 
> SRC_URI[mru.sha256sum] =
> "01d9fc04f83740c513c25401dcc89c11b2a5a6013e70bfca42b7b02129f88cd2" 
> -SRC_URI[ssvb.md5sum] = "0acc570d943c41c7f8602b9ff6fa111d" 
> -SRC_URI[ssvb.sha256sum] =
> "bfddd3226a499ffdf71bb58c05ccdc6dac5bb2c2c3bdb10ac610ee0b60aac087" 
> +SRC_URI[ssvb.md5sum] = "ba0ef2939a3b3b487523448c67544e94" 
> +SRC_URI[ssvb.sha256sum] =
> "ce42ebdc71c876a33d9f7534355ef76cefa0d00ddb19ad69cf05a266c861d08d"
> 
> S = "${WORKDIR}"
> 
> do_compile() { ${CC} ${CFLAGS} ${LDFLAGS} burn.S -o burn -    ${CC}
> ${CFLAGS} ${LDFLAGS} ssvb-cpuburn-a8.S -o burn-neona8 +    ${CC}
> ${CFLAGS} ${LDFLAGS} cpuburn-a8.S -o burn-neona8 }
> 
> do_install() {
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTrTmDMkyGM64RGpERAjXBAJ4s5eQ6sg0h4h3D62Vq8ULr+8tzKQCgkAKY
11UopJhFG8CsPTl/mxMv7Ck=
=jm+c
-----END PGP SIGNATURE-----

Re: [meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Otavio Salvador]

Hello Koen,

On Fri, Jun 27, 2014 at 6:29 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Lauren Post schreef op 26-06-14 16:37:
>> Replace SRC_URI with new location, md5sum and new name since previous
>> download will not work.  Without this fix cpuburn-neon has a broken
>> build.
>
> Why not make the recipe clone the git repo?

I pondered about this when looking at the issue with Lauren. The
recipe was like this before and this build break is causing issues for
several people using meta-fsl-demos as we include it in our test
images.

The long term solution should be to rework it (also because it has
extra tests and those are not being included) but I think this fix is
urgent and known to work for now.

This fix needs to be backported to old branches as well as current
recipe fails to fetch.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Koen Kooi]

Op 27 jun. 2014, om 15:09 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:

> Hello Koen,
> 
> On Fri, Jun 27, 2014 at 6:29 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Lauren Post schreef op 26-06-14 16:37:
>>> Replace SRC_URI with new location, md5sum and new name since previous
>>> download will not work.  Without this fix cpuburn-neon has a broken
>>> build.
>> 
>> Why not make the recipe clone the git repo?
> 
> I pondered about this when looking at the issue with Lauren. The
> recipe was like this before and this build break is causing issues for
> several people using meta-fsl-demos as we include it in our test
> images.
> 
> The long term solution should be to rework it (also because it has
> extra tests and those are not being included) but I think this fix is
> urgent and known to work for now.

It's still the wrong way to fix it, rework it to use git://, this will break again when the repo gets updated.

> This fix needs to be backported to old branches as well as current
> recipe fails to fetch.

if you're going to backport it make sure it's the right fix.


> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> 

Re: [meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Otavio Salvador]

Hello Koen,

On Fri, Jun 27, 2014 at 10:40 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 27 jun. 2014, om 15:09 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
>
>> Hello Koen,
>>
>> On Fri, Jun 27, 2014 at 6:29 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> Lauren Post schreef op 26-06-14 16:37:
>>>> Replace SRC_URI with new location, md5sum and new name since previous
>>>> download will not work.  Without this fix cpuburn-neon has a broken
>>>> build.
>>>
>>> Why not make the recipe clone the git repo?
>>
>> I pondered about this when looking at the issue with Lauren. The
>> recipe was like this before and this build break is causing issues for
>> several people using meta-fsl-demos as we include it in our test
>> images.
>>
>> The long term solution should be to rework it (also because it has
>> extra tests and those are not being included) but I think this fix is
>> urgent and known to work for now.
>
> It's still the wrong way to fix it, rework it to use git://, this will break again when the repo gets updated.
>
>> This fix needs to be backported to old branches as well as current
>> recipe fails to fetch.
>
> if you're going to backport it make sure it's the right fix.

Instead we can use, for now, the below URL so it stays working even if
it is updated.

https://raw.githubusercontent.com/ssvb/cpuburn-arm/dd5c5ba58d2b0b23cfab4a286f9d3f5510000f20/cpuburn-a8.S

Fine for this fix? I will update it to use the clone and also include
the extra tests (for A8, A9 and A7 plus the JPEG ones) soon.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-oe][PATCH] cpuburn-neon: Upgrade to 2014066 version to fix build break

[Koen Kooi]

Op 27 jun. 2014, om 15:59 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:

> Hello Koen,
> 
> On Fri, Jun 27, 2014 at 10:40 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> 
>> Op 27 jun. 2014, om 15:09 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:
>> 
>>> Hello Koen,
>>> 
>>> On Fri, Jun 27, 2014 at 6:29 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>>> Lauren Post schreef op 26-06-14 16:37:
>>>>> Replace SRC_URI with new location, md5sum and new name since previous
>>>>> download will not work.  Without this fix cpuburn-neon has a broken
>>>>> build.
>>>> 
>>>> Why not make the recipe clone the git repo?
>>> 
>>> I pondered about this when looking at the issue with Lauren. The
>>> recipe was like this before and this build break is causing issues for
>>> several people using meta-fsl-demos as we include it in our test
>>> images.
>>> 
>>> The long term solution should be to rework it (also because it has
>>> extra tests and those are not being included) but I think this fix is
>>> urgent and known to work for now.
>> 
>> It's still the wrong way to fix it, rework it to use git://, this will break again when the repo gets updated.
>> 
>>> This fix needs to be backported to old branches as well as current
>>> recipe fails to fetch.
>> 
>> if you're going to backport it make sure it's the right fix.
> 
> Instead we can use, for now, the below URL so it stays working even if
> it is updated.
> 
> https://raw.githubusercontent.com/ssvb/cpuburn-arm/dd5c5ba58d2b0b23cfab4a286f9d3f5510000f20/cpuburn-a8.S
> 
> Fine for this fix?

A lot less fragile :)

> I will update it to use the clone and also include
> the extra tests (for A8, A9 and A7 plus the JPEG ones) soon.
> 
> -- 
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750