All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Raible <raible@gmail.com>
To: git@vger.kernel.org
Subject: Re: Git in next is broken
Date: Fri, 13 Nov 2009 20:20:47 +0000 (UTC)	[thread overview]
Message-ID: <loom.20091113T211800-4@post.gmane.org> (raw)
In-Reply-To: alpine.LFD.2.00.0911131152120.16711@xanadu.home

Nicolas Pitre <nico <at> fluxnic.net> writes:

 > diff --git a/remote.c b/remote.c
> > index 4f9f0cc..6195a58 100644
> > --- a/remote.c
> > +++ b/remote.c
> > @@ -754,6 +754,8 @@ void ref_remove_duplicates(struct ref *ref_map)
> >                         prev->next = ref_map->next;
> >                         free(ref_map->peer_ref);
> >                         free(ref_map);
> > +                       ref_map = prev; // Keep the same prev.
> > +                       continue;
> >                 }
> > 

This is one of those example where the comment is essentially useless.
Wouldn't something like "// Skip the freed item" be more useful?

- Eric

  reply	other threads:[~2009-11-13 20:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 20:36 Git in next is broken Nicolas Pitre
2009-11-12 22:17 ` René Scharfe
2009-11-12 22:45   ` Julian Phillips
2009-11-13  4:50     ` Nicolas Pitre
2009-11-13  9:14       ` Julian Phillips
2009-11-13 16:54         ` Nicolas Pitre
2009-11-13 20:20           ` Eric Raible [this message]
2009-11-13 21:25           ` [PATCH] remote: Fix glibc error in ref_remove_duplicates Julian Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20091113T211800-4@post.gmane.org \
    --to=raible@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.