All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Simon Horman <horms@verge.net.au>,
	kexec-ml <kexec@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.
Date: Mon, 13 Jul 2009 10:06:25 -0700	[thread overview]
Message-ID: <m14otga4xa.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A5AB903.6090204@mxs.nes.nec.co.jp> (Ken'ichi Ohmichi's message of "Mon\, 13 Jul 2009 13\:33\:07 +0900")

"Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp> writes:

> Hi,
>
> This patch is a new version by Seto-san's comment.
>
>
> Changelog since v1:
> * Remove the check code other than kexec_crash_image from kexec_should_crash()
>   because a kexec cannot crash if there is no image.
>
>
> This patch enables a kdump if 2nd-kernel is loaded.
> (The patch is based on linux-2.6.31-rc2.)
>
> Now, a kdump on oops is enabled if a kernel parameter "oops=panic"
> is specified and 2nd-kernel is loaded. I think that a kdump should
> be enabled regardless of "oops=panic" if 2nd-kernel is loaded,
> because a system administrator loads 2nd-kernel for enabling a kdump.

The Documentation for sysrq-c certainly needs to be updated.

If I am doing development on a system I like oops's.  All of the
information and nothing goes down.  I can get at /proc/kcore etc.

In a setting where I can't be Johnny on the spot and look at
things a core dump is probably the best I can get.  In that scenario
panic_on_oops sounds good.

As I read the current check it reads:
If we are going to panic and not oops || panic_on_oops
	kexec_should_crash = true;

Which seems a very reasonable implementation of policy.

Eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	kexec-ml <kexec@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.
Date: Mon, 13 Jul 2009 10:06:25 -0700	[thread overview]
Message-ID: <m14otga4xa.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A5AB903.6090204@mxs.nes.nec.co.jp> (Ken'ichi Ohmichi's message of "Mon\, 13 Jul 2009 13\:33\:07 +0900")

"Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp> writes:

> Hi,
>
> This patch is a new version by Seto-san's comment.
>
>
> Changelog since v1:
> * Remove the check code other than kexec_crash_image from kexec_should_crash()
>   because a kexec cannot crash if there is no image.
>
>
> This patch enables a kdump if 2nd-kernel is loaded.
> (The patch is based on linux-2.6.31-rc2.)
>
> Now, a kdump on oops is enabled if a kernel parameter "oops=panic"
> is specified and 2nd-kernel is loaded. I think that a kdump should
> be enabled regardless of "oops=panic" if 2nd-kernel is loaded,
> because a system administrator loads 2nd-kernel for enabling a kdump.

The Documentation for sysrq-c certainly needs to be updated.

If I am doing development on a system I like oops's.  All of the
information and nothing goes down.  I can get at /proc/kcore etc.

In a setting where I can't be Johnny on the spot and look at
things a core dump is probably the best I can get.  In that scenario
panic_on_oops sounds good.

As I read the current check it reads:
If we are going to panic and not oops || panic_on_oops
	kexec_should_crash = true;

Which seems a very reasonable implementation of policy.

Eric

  parent reply	other threads:[~2009-07-13 17:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  8:05 [PATCH] kdump: Enable kdump if 2nd-kernel is loaded Ken'ichi Ohmichi
2009-07-09  8:05 ` Ken'ichi Ohmichi
2009-07-10  6:32 ` Hidetoshi Seto
2009-07-10  6:32   ` Hidetoshi Seto
2009-07-10  7:05   ` Ken'ichi Ohmichi
2009-07-10  7:05     ` Ken'ichi Ohmichi
2009-07-10  7:52     ` Hidetoshi Seto
2009-07-10  7:52       ` Hidetoshi Seto
2009-07-13  4:33   ` [PATCH-v2] " Ken'ichi Ohmichi
2009-07-13  4:33     ` Ken'ichi Ohmichi
2009-07-13  7:48     ` Hidetoshi Seto
2009-07-13  7:48       ` Hidetoshi Seto
2009-07-13 17:06     ` Eric W. Biederman [this message]
2009-07-13 17:06       ` Eric W. Biederman
2009-07-14  2:04       ` Hidetoshi Seto
2009-07-14  2:04         ` Hidetoshi Seto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m14otga4xa.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oomichi@mxs.nes.nec.co.jp \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.