From: ebiederm@xmission.com (Eric W. Biederman)
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Davide Libenzi <davidel@xmailserver.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Robin Holt <holt@sgi.com>, Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] make kernel threads invisible to /sbin/init
Date: Tue, 10 Apr 2007 21:29:11 -0600 [thread overview]
Message-ID: <m17isjwpvc.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070410231604.GA19852@vino.hallyn.com> (Serge E. Hallyn's message of "Tue, 10 Apr 2007 18:16:04 -0500")
"Serge E. Hallyn" <serge@hallyn.com> writes:
> Quoting Oleg Nesterov (oleg@tv-sign.ru):
>> 1. rename reparent_to_init() to reparent_kthread() and export it
>>
>> 2. use init_pid_ns.child_reaper instead of child_reaper(current)
>
> Each of these patches looks good to me, but this part in particular
> is a must-have bugfix.
Removing daemonize is a must have bug fix. This falls short of that so
it is a good fix, but it doesn't solve the core problem that kernel daemons
are being assigned pids inside of child pid namespaces.
It doesn't solve the problem that some kernel daemons are using signals
to communicate with user space.
It doesn't solve the problem that we have to do a lot of massaging and
maintenance to get kernel threads from grabbing references to namespaces
and other kernel pieces they should not be grabbing.
Eric
next prev parent reply other threads:[~2007-04-11 3:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 18:51 [PATCH 2/3] make kernel threads invisible to /sbin/init Oleg Nesterov
2007-04-10 23:16 ` Serge E. Hallyn
2007-04-11 3:29 ` Eric W. Biederman [this message]
2007-04-11 3:56 ` Eric W. Biederman
2007-04-11 11:42 ` Oleg Nesterov
2007-04-11 5:44 ` [PATCH] kthread: Don't depend on work queues Eric W. Biederman
2007-04-11 7:03 ` Andrew Morton
2007-04-11 10:13 ` Rafael J. Wysocki
2007-04-11 11:21 ` Gautham R Shenoy
2007-04-11 11:48 ` Oleg Nesterov
2007-04-11 13:31 ` Gautham R Shenoy
2007-04-11 14:36 ` Oleg Nesterov
2007-04-11 19:37 ` Rafael J. Wysocki
2007-04-11 14:44 ` Rafael J. Wysocki
2007-04-11 18:22 ` Eric W. Biederman
2007-04-11 18:27 ` [PATCH] kthread: Don't depend on work queues (take 2) Eric W. Biederman
2007-04-11 18:49 ` [PATCH] Change reparent_to_init to reparent_to_kthreadd Eric W. Biederman
2007-04-11 19:21 ` [PATCH] kthread: Don't depend on work queues (take 2) Andrew Morton
2007-04-11 19:28 ` Oleg Nesterov
2007-04-11 19:40 ` Eric W. Biederman
2007-04-11 19:49 ` Oleg Nesterov
2007-04-11 20:02 ` Eric W. Biederman
2007-04-11 12:04 ` [PATCH] kthread: Don't depend on work queues Oleg Nesterov
2007-04-11 16:25 ` Eric W. Biederman
2007-04-11 13:15 ` Oleg Nesterov
2007-04-11 16:22 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17isjwpvc.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=holt@sgi.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.