From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
Joerg Roedel <joerg.roedel@amd.com>,
Weidong Han <weidong.han@intel.com>,
dwmw2@infradead.org, suresh.b.siddha@intel.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Intel-IOMMU, intr-remap: source-id checking
Date: Wed, 20 May 2009 05:24:49 -0700 [thread overview]
Message-ID: <m1fxf0klm6.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20090520082114.GC6736@elte.hu> (Ingo Molnar's message of "Wed\, 20 May 2009 10\:21\:14 +0200")
Ingo Molnar <mingo@elte.hu> writes:
>> The table of apic information by apic_id also seems wrong. Don't
>> we have chip_data or something that should point it that we can
>> get from the irq?
>
> ->chip_data is already used for io-apic configuration bits - if it's
> reused then the right way to do it is to extend struct irq_cfg in
> arch/x86/kernel/apic/io_apic.c.
We are talking about some extra io-apic configuration bits, that
happen to currently be private to dmar.c.
chip_data, handler_data I can never keep those straight except
when I am deep in the code. What I do know is that encouraging
more arrays of size MAX_IO_APICS seems like the wrong direction.
Which probably means adding the information we need to struct irq_cfg.
Eric
next prev parent reply other threads:[~2009-05-20 12:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 18:31 [PATCH v2 0/2] Intel-IOMMU: source-id checking for interrupt remapping Weidong Han
2009-05-19 18:31 ` [PATCH v2 1/2] Intel-IOMMU, intr-remap: set the whole 128bits of irte when modify/free it Weidong Han
2009-05-19 12:14 ` Ingo Molnar
2009-05-19 14:15 ` Han, Weidong
2009-05-19 18:31 ` [PATCH v2 2/2] Intel-IOMMU, intr-remap: source-id checking Weidong Han
2009-05-19 11:50 ` Ingo Molnar
2009-05-19 14:12 ` Han, Weidong
2009-05-19 19:28 ` Eric W. Biederman
2009-05-20 8:21 ` Ingo Molnar
2009-05-20 8:38 ` Han, Weidong
2009-05-20 12:13 ` Eric W. Biederman
2009-05-20 9:43 ` Joerg Roedel
2009-05-20 12:02 ` Eric W. Biederman
2009-05-20 12:24 ` Eric W. Biederman [this message]
2009-05-21 9:00 ` Han, Weidong
2009-05-21 10:04 ` Eric W. Biederman
2009-05-21 13:37 ` Han, Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fxf0klm6.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=weidong.han@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.