From: Andi Kleen <ak@muc.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: Locking model for NAPI drivers
Date: Wed, 01 Jun 2005 08:28:04 +0200 [thread overview]
Message-ID: <m1fyw2wpzf.fsf@muc.de> (raw)
In-Reply-To: <20050531.154847.63995530.davem@davemloft.net> (David S. Miller's message of "Tue, 31 May 2005 15:48:47 -0700 (PDT)")
"David S. Miller" <davem@davemloft.net> writes:
Stupid question, but...
> I was doing some brainstorming to try and fix a nagging problem in
> the tg3 driver which suggested that doing the SMP locking differently
> might be the best and cleanest solution.
>
> The tg3 problem is that it can do an skb_copy() in HW IRQ disabled
> context which is illegal.
That is because of the kmap_atomic it does right? At least in the i386
highmem implementation I don't see any code that would be less safe in
hard interrupt context compared to BHs. And FRV and mips look like they
allow it too.
> This fixes the skb_copy() we were doing with hw
> IRQs disabled (which is illegal and triggers a
> BUG() with HIGHMEM enabled).
Which BUG did it trigger?
-Andi
next prev parent reply other threads:[~2005-06-01 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 22:48 Locking model for NAPI drivers David S. Miller
2005-06-01 6:28 ` Andi Kleen [this message]
2005-06-01 8:42 ` Herbert Xu
2005-06-01 8:16 ` Greg Banks
2005-06-01 20:33 ` Michael Chan
2005-06-01 22:21 ` David S. Miller
2005-06-01 21:34 ` Michael Chan
2005-06-02 19:56 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fyw2wpzf.fsf@muc.de \
--to=ak@muc.de \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.