From: ebiederm@xmission.com (Eric W. Biederman)
To: Rik van Riel <riel@conectiva.com.br>
Cc: "David S. Miller" <davem@redhat.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: 2.4.14 + Bug in swap_out.
Date: 21 Nov 2001 06:31:51 -0700 [thread overview]
Message-ID: <m1hero1c8o.fsf@frodo.biederman.org> (raw)
In-Reply-To: <Pine.LNX.4.33L.0111211016270.4079-100000@imladris.surriel.com>
In-Reply-To: <Pine.LNX.4.33L.0111211016270.4079-100000@imladris.surriel.com>
Rik van Riel <riel@conectiva.com.br> writes:
> On 20 Nov 2001, Eric W. Biederman wrote:
> > "David S. Miller" <davem@redhat.com> writes:
> >
> > > I do not agree with your analysis.
> >
> > Neither do I now but not for your reasons :)
> >
> > I looked again we are o.k. but just barely. mmput explicitly checks
> > to see if it is freeing the swap_mm, and fixes if we are. It is a
> > nasty interplay with the swap_mm global, but the code is correct.
>
> To be honest I don't see the reason for this subtle
> playing with swap_mm in mmput(), since the refcounting
> should mean we're safe.
We only hold a ref count for the duration of swap_out_mm.
Not for the duration of the value in swap_mm.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Rik van Riel <riel@conectiva.com.br>
Cc: "David S. Miller" <davem@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: 2.4.14 + Bug in swap_out.
Date: 21 Nov 2001 06:31:51 -0700 [thread overview]
Message-ID: <m1hero1c8o.fsf@frodo.biederman.org> (raw)
In-Reply-To: <Pine.LNX.4.33L.0111211016270.4079-100000@imladris.surriel.com>
Rik van Riel <riel@conectiva.com.br> writes:
> On 20 Nov 2001, Eric W. Biederman wrote:
> > "David S. Miller" <davem@redhat.com> writes:
> >
> > > I do not agree with your analysis.
> >
> > Neither do I now but not for your reasons :)
> >
> > I looked again we are o.k. but just barely. mmput explicitly checks
> > to see if it is freeing the swap_mm, and fixes if we are. It is a
> > nasty interplay with the swap_mm global, but the code is correct.
>
> To be honest I don't see the reason for this subtle
> playing with swap_mm in mmput(), since the refcounting
> should mean we're safe.
We only hold a ref count for the duration of swap_out_mm.
Not for the duration of the value in swap_mm.
Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-11-21 13:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-21 6:01 2.4.14 + Bug in swap_out Eric W. Biederman
2001-11-21 6:01 ` Eric W. Biederman
2001-11-21 6:29 ` David S. Miller
2001-11-21 6:29 ` David S. Miller
2001-11-21 6:37 ` Eric W. Biederman
2001-11-21 6:37 ` Eric W. Biederman
2001-11-21 12:17 ` Rik van Riel
2001-11-21 12:17 ` Rik van Riel
2001-11-21 13:31 ` Eric W. Biederman [this message]
2001-11-21 13:31 ` Eric W. Biederman
2001-11-21 14:20 ` Rik van Riel
2001-11-21 14:20 ` Rik van Riel
2001-11-21 14:21 ` Eric W. Biederman
2001-11-21 14:21 ` Eric W. Biederman
2001-11-21 15:34 ` Hugh Dickins
2001-11-21 15:39 ` Rik van Riel
2001-11-21 15:39 ` Rik van Riel
2001-11-21 16:19 ` Hugh Dickins
2001-11-21 16:26 ` Eric W. Biederman
2001-11-21 16:26 ` Eric W. Biederman
2001-11-21 17:45 ` Hugh Dickins
2001-11-21 12:13 ` Rik van Riel
2001-11-21 12:13 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1hero1c8o.fsf@frodo.biederman.org \
--to=ebiederm@xmission.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.