From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [RFC][patch 0/1] fix allnoconfig for net-2.6.24
Date: Wed, 12 Sep 2007 11:23:41 -0600 [thread overview]
Message-ID: <m1lkbb94rm.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070912170739.187625566-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org> (dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org's message of "Wed, 12 Sep 2007 19:07:39 +0200")
dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org writes:
> The kernel compilation fails with allnoconfig with an unresolved to init_net.
> I tryed to figure out how to fix that. The problem is raised because the
> init_net
> variable is defined as extern in net_namespace.h while the variable is declared
> in net_namespace.c. This file is not compiled because of the config options and
> that leads to the compilation error.
>
> I noticed the uts namespace defines the init_uts_ns in init/version.c, so I
> moved
> the init_net to this file too. The compilation error is fixed.
>
> But I don't like really this approach because:
> 1 - we fall under a part not covered by the network
> 2 - we add a new include net_namespace.h in version.c
>
> Does this fix seems correct ? I just want to fix it for now to have net-2.6.24
> compiling for all configs.
Thanks for the testing and catching all of the little nit picky things.
Where is init_net used that is a problem with allnoconfig?
Eric
next prev parent reply other threads:[~2007-09-12 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 17:07 [RFC][patch 0/1] fix allnoconfig for net-2.6.24 dlezcano-NmTC/0ZBporQT0dZR+AlfA
2007-09-12 17:07 ` [RFC][patch 1/1] From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org> dlezcano-NmTC/0ZBporQT0dZR+AlfA
[not found] ` <20070912170739.187625566-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org>
2007-09-12 17:23 ` Eric W. Biederman [this message]
2007-09-12 17:45 ` [RFC][patch 0/1] fix allnoconfig for net-2.6.24 Eric W. Biederman
[not found] ` <m1hclz93rg.fsf-T1Yj925okcoyDheHMi7gv2pdwda3JcWeAL8bYrjMMd8@public.gmane.org>
2007-09-12 19:37 ` Daniel Lezcano
[not found] ` <46E84008.1000001-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-09-12 19:45 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1lkbb94rm.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.