Re: [CFT] [PATCH] kexec 2.5.44 (minimal)

[ebiederm@xmission.com (Eric W. Biederman)]

Andy Pfiffer <andyp@osdl.org> writes:

> On Mon, 2002-10-28 at 00:16, Eric W. Biederman wrote:
> > And is currently kept in two pieces.
> > The pure system call.
> > http://www.xmission.com/~ebiederm/files/kexec/linux-2.5.44.x86kexec-2.diff
> > 
> > And the set of hardware fixes known to help kexec.
> >
> http://www.xmission.com/~ebiederm/files/kexec/linux-2.5.44.x86kexec-hwfixes.diff
> 
> 
> Eric,
> 
> Hmmm... I'm having a lot more problems on my troublesome machine with
> this patchset than I did with the previous iteration.  I've
> triple-checked the application of the patches, but I can't even get
> kexec_test to start, much less run to completion.
> 
> The new behavior is that the system appears to hang immediately after
> invoking "kexec kexec_test".
> 
> What could I have done wrong?

With out some amount of output I don't have a clue.

With just the first patch it doesn't work on SMP, but I don't try it to see
what the failure mode was.

With the second patch all should be the same except the legacy pic actually
gets disabled.  I wonder if disabling the legacy pic locks your system?

There should be two printks one about shuting down devices,
and another about kexecing the image.  And knowing when which of those
printed could be useful.

In any event.  Remove the shutdown routine in arch/i386/kernel/i8259.c
That should restore the kernel to it's previous behavior if something really changed...

 static struct device_driver i8259A_driver = {
 	.name		= "pic",
 	.bus		= &system_bus_type,
 	.resume		= i8259A_resume,
- 	.shutdown	= i8259A_shutdown,
 };

Or you could try it with a uniprocessor kernel and just the first patch.

Eric