All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
	"David P. Quigley" <dpquigl@tycho.nsa.gov>,
	jmorris@namei.org, gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] Security/sysfs: v2 - Enable security xattrs to be set on sysfs files, directories, and symlinks.
Date: Wed, 19 Aug 2009 19:41:41 -0700	[thread overview]
Message-ID: <m1skfni4uy.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A8C91D4.3070308@schaufler-ca.com> (Casey Schaufler's message of "Wed\, 19 Aug 2009 16\:59\:16 -0700")

Casey Schaufler <casey@schaufler-ca.com> writes:

> So I still don't like the way it exposes LSM internal data to the
> file system code, but given how long it's taking for me to create
> a better solution I don't think that I can in all fairness say NAK
> to David Quigley's sysfs patch any longer. I withdraw my objection,
> while maintaining my reservations.

Until I see it wired up against another filesystem I retain my
objections.  When I asked he pretty much told me that it doesn't
generalize to other filesystems well and it is a sysfs special case.

The way sysctl and proc are wired as special cases into the lsm
has been a maintenance disaster so far, and I think it a very bad
idea to add yet another lsm special case, that supports only one
filesystem.

Eric

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
	"David P. Quigley" <dpquigl@tycho.nsa.gov>,
	jmorris@namei.org, gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] Security/sysfs: v2 - Enable security xattrs to be set on sysfs files, directories, and symlinks.
Date: Wed, 19 Aug 2009 19:41:41 -0700	[thread overview]
Message-ID: <m1skfni4uy.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A8C91D4.3070308@schaufler-ca.com> (Casey Schaufler's message of "Wed\, 19 Aug 2009 16\:59\:16 -0700")

Casey Schaufler <casey@schaufler-ca.com> writes:

> So I still don't like the way it exposes LSM internal data to the
> file system code, but given how long it's taking for me to create
> a better solution I don't think that I can in all fairness say NAK
> to David Quigley's sysfs patch any longer. I withdraw my objection,
> while maintaining my reservations.

Until I see it wired up against another filesystem I retain my
objections.  When I asked he pretty much told me that it doesn't
generalize to other filesystems well and it is a sysfs special case.

The way sysctl and proc are wired as special cases into the lsm
has been a maintenance disaster so far, and I think it a very bad
idea to add yet another lsm special case, that supports only one
filesystem.

Eric

  reply	other threads:[~2009-08-20  2:41 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 13:48 [PATCH] Security/sysfs: Enable security xattrs to be set on sysfs files, directories, and symlinks David P. Quigley
2009-07-15 13:48 ` David P. Quigley
2009-07-15 14:28 ` David P. Quigley
2009-07-15 14:28   ` David P. Quigley
2009-07-15 14:31 ` David P. Quigley
2009-07-15 14:31   ` David P. Quigley
2009-07-21 16:29 ` David P. Quigley
2009-07-21 16:29   ` David P. Quigley
2009-07-21 16:49   ` Greg KH
2009-07-21 16:49     ` Greg KH
2009-07-21 16:34 ` David P. Quigley
2009-07-21 16:34   ` David P. Quigley
2009-07-21 17:01   ` David P. Quigley
2009-07-21 17:01     ` David P. Quigley
2009-07-24  8:13     ` James Morris
2009-07-24  8:13       ` James Morris
2009-07-24 14:34       ` David P. Quigley
2009-07-24 14:34         ` David P. Quigley
2009-07-24 14:54         ` Casey Schaufler
2009-07-24 14:54           ` Casey Schaufler
2009-08-14  4:59 ` Casey Schaufler
2009-08-14  4:59   ` Casey Schaufler
2009-08-14 12:20   ` Stephen Smalley
2009-08-14 12:20     ` Stephen Smalley
2009-08-14 12:40     ` Stephen Smalley
2009-08-14 12:40       ` Stephen Smalley
2009-08-15  1:33       ` Casey Schaufler
2009-08-15  1:33         ` Casey Schaufler
2009-08-17 12:01         ` Stephen Smalley
2009-08-17 12:01           ` Stephen Smalley
2009-08-15  1:19     ` Casey Schaufler
2009-08-15  1:19       ` Casey Schaufler
2009-08-17 11:53       ` Stephen Smalley
2009-08-17 11:53         ` Stephen Smalley
2009-08-14 22:02   ` Eric W. Biederman
2009-08-14 22:02     ` Eric W. Biederman
2009-08-15  1:42     ` Casey Schaufler
2009-08-15  1:42       ` Casey Schaufler
2009-08-15  2:15       ` Eric W. Biederman
2009-08-15  2:15         ` Eric W. Biederman
2009-08-15  4:56         ` Casey Schaufler
2009-08-15  4:56           ` Casey Schaufler
2009-08-15  6:01           ` Eric W. Biederman
2009-08-15  6:01             ` Eric W. Biederman
2009-08-16 17:25             ` Casey Schaufler
2009-08-16 17:25               ` Casey Schaufler
2009-08-18  3:55             ` [PATCH] Security/sysfs: v2 - " Casey Schaufler
2009-08-18  3:55               ` Casey Schaufler
2009-08-18 12:14               ` Stephen Smalley
2009-08-18 12:14                 ` Stephen Smalley
2009-08-18 14:12                 ` Casey Schaufler
2009-08-18 14:12                   ` Casey Schaufler
2009-08-18 14:23                   ` Stephen Smalley
2009-08-18 14:23                     ` Stephen Smalley
2009-08-19  4:37                     ` Casey Schaufler
2009-08-19  4:37                       ` Casey Schaufler
2009-08-19 11:58                       ` Stephen Smalley
2009-08-19 11:58                         ` Stephen Smalley
2009-08-19 17:47                         ` Casey Schaufler
2009-08-19 17:47                           ` Casey Schaufler
2009-08-19 23:59                         ` Casey Schaufler
2009-08-19 23:59                           ` Casey Schaufler
2009-08-20  2:41                           ` Eric W. Biederman [this message]
2009-08-20  2:41                             ` Eric W. Biederman
2009-08-20 11:53                             ` Stephen Smalley
2009-08-20 11:53                               ` Stephen Smalley
2009-08-20 13:18 ` [PATCH] Security/sysfs: " David P. Quigley
2009-08-20 13:18   ` David P. Quigley
2009-08-21  3:38   ` Casey Schaufler
2009-08-21  3:38     ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1skfni4uy.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=casey@schaufler-ca.com \
    --cc=dpquigl@tycho.nsa.gov \
    --cc=gregkh@suse.de \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.