All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Creekmore <jonathan.creekmore@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Jonathan Creekmore <jonathan.creekmore@gmail.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 2/5] build: Hook the schedulers into Kconfig
Date: Thu, 14 Jan 2016 10:23:52 -0600	[thread overview]
Message-ID: <m21t9k3zaf.fsf@Nebula.lan> (raw)
In-Reply-To: <5697D71D02000078000C6DE6@prv-mh.provo.novell.com>


Jan Beulich writes:

>>>> On 14.01.16 at 15:49, <jonathan.creekmore@gmail.com> wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -51,4 +51,63 @@ config KEXEC
>>
>>  	  If unsure, say Y.
>>
>> +# Enable schedulers
>> +menu "Schedulers"
>> +	visible if EXPERT = "y"
>> +
>> +config SCHED_CREDIT
>> +	bool
>> +	default y
>> +	---help---
>> +	  The traditional credit scheduler is a general purpose scheduler.
>
> So is this option now useful for anything?

It keeps the code between all of the schedulers consistent (all of them
have a #define if they are compiled it) and helps keep my downstream
patch smaller.

>
>> +choice
>> +	prompt "Default Scheduler?"
>> +	default SCHED_CREDIT_DEFAULT if SCHED_CREDIT
>> +	default SCHED_CREDIT2_DEFAULT if SCHED_CREDIT2
>> +	default SCHED_RTDS_DEFAULT if SCHED_RTDS
>> +	default SCHED_ARINC653_DEFAULT if SCHED_ARINC653
>
> And certainly all these defaults are now pointless, considering
> that the condition of the first one is "if y".

Yes, I could rip all of those out now since credit is always the
default. I left it in there for the ideal case that credit didn't have
to be special cased but, at this point, I will rip it out if you want.

  reply	other threads:[~2016-01-14 16:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 14:49 [PATCH v5 0/5] Allow schedulers to be selectable through Kconfig Jonathan Creekmore
2016-01-14 14:49 ` [PATCH v5 1/5] build: Env var to enable expert config options Jonathan Creekmore
2016-01-14 16:09   ` Jan Beulich
2016-01-15 15:47     ` Ian Campbell
2016-01-15 16:56       ` Jan Beulich
2016-01-14 14:49 ` [PATCH v5 2/5] build: Hook the schedulers into Kconfig Jonathan Creekmore
2016-01-14 16:13   ` Jan Beulich
2016-01-14 16:23     ` Jonathan Creekmore [this message]
2016-01-14 16:34       ` Ian Campbell
2016-01-14 16:44         ` Jan Beulich
2016-01-14 16:58           ` Ian Campbell
2016-01-14 17:22           ` Jonathan Creekmore
2016-01-14 14:49 ` [PATCH v5 3/5] build: Alloc space for sched list in the link file Jonathan Creekmore
2016-01-14 14:49 ` [PATCH v5 4/5] sched: Register the schedulers into the list Jonathan Creekmore
2016-01-14 14:49 ` [PATCH v5 5/5] sched: Use the auto-generated list of schedulers Jonathan Creekmore
2016-01-14 16:17   ` Jan Beulich
2016-01-14 16:25     ` Jonathan Creekmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21t9k3zaf.fsf@Nebula.lan \
    --to=jonathan.creekmore@gmail.com \
    --cc=JBeulich@suse.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.