From: Andi Kleen <andi@firstfloor.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Matthew Garrett <mjg@redhat.com>,
Khalid Aziz <khalid.aziz@hp.com>,
linux-kernel@vger.kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] Disable Bus Master on PCI device shutdown
Date: Thu, 07 Jun 2012 10:07:29 -0700 [thread overview]
Message-ID: <m21ulrjbji.fsf@firstfloor.org> (raw)
In-Reply-To: <20120606215034.257d7549@pyramind.ukuu.org.uk> (Alan Cox's message of "Wed, 6 Jun 2012 21:50:34 +0100")
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
>> This protects against the case where a piece of hardware is continuing
>> to DMA even after the driver shutdown method has been called? I'm not
>
> It doesn't. We also have hardware which craps itself if you clear the bus
> mastering bit and we have platforms where the BIOS gets most upset if you
> do that on suspend paths. There are also lots of devices that simply
> ignore the bus mastering bit !
But it also makes my system do kexec successfully for the first time.
Maybe can make it an option.
n-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-06-07 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 19:00 [PATCH] Disable Bus Master on PCI device shutdown Khalid Aziz
2012-05-03 23:52 ` Bjorn Helgaas
2012-05-04 17:15 ` Bjorn Helgaas
2012-06-06 13:50 ` Matthew Garrett
2012-06-06 16:17 ` Khalid Aziz
2012-06-06 16:27 ` Matthew Garrett
2012-06-06 17:32 ` Khalid Aziz
2012-06-06 17:42 ` Matthew Garrett
2012-06-06 18:07 ` Khalid Aziz
2012-06-06 19:42 ` Eric W. Biederman
2012-06-06 20:09 ` Matthew Garrett
2012-06-07 17:43 ` Khalid Aziz
2012-06-07 14:21 ` Khalid Aziz
2012-06-06 20:16 ` Myron Stowe
2012-06-06 23:03 ` Khalid Aziz
2012-06-06 23:18 ` Myron Stowe
2012-06-06 20:50 ` Alan Cox
2012-06-07 17:07 ` Andi Kleen [this message]
2012-06-07 17:13 ` Alan Cox
2012-06-07 17:36 ` Khalid Aziz
2012-06-07 17:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21ulrjbji.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bhelgaas@google.com \
--cc=khalid.aziz@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.