* [PATCH 1/1] of_mmc_spi: fix little endian support
@ 2012-01-30 4:15 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 8+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-01-30 4:15 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Grant Likely, linux-mmc, Jean-Christophe PLAGNIOL-VILLARD
the voltage_ranges is supposed to switch from big endian to little endian
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-mmc@vger.kernel.org
---
drivers/mmc/host/of_mmc_spi.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index ab66f24..ede2c64 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -109,12 +109,13 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
goto err_ocr;
}
+
for (i = 0; i < num_ranges; i++) {
const int j = i * 2;
u32 mask;
- mask = mmc_vddrange_to_ocrmask(voltage_ranges[j],
- voltage_ranges[j + 1]);
+ mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
+ be32_to_cpu(voltage_ranges[j + 1]));
if (!mask) {
ret = -EINVAL;
dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
--
1.7.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] of_mmc_spi: fix little endian support
@ 2012-01-30 4:15 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 8+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-01-30 4:15 UTC (permalink / raw)
To: linux-arm-kernel
the voltage_ranges is supposed to switch from big endian to little endian
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-mmc at vger.kernel.org
---
drivers/mmc/host/of_mmc_spi.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index ab66f24..ede2c64 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -109,12 +109,13 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
goto err_ocr;
}
+
for (i = 0; i < num_ranges; i++) {
const int j = i * 2;
u32 mask;
- mask = mmc_vddrange_to_ocrmask(voltage_ranges[j],
- voltage_ranges[j + 1]);
+ mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
+ be32_to_cpu(voltage_ranges[j + 1]));
if (!mask) {
ret = -EINVAL;
dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
--
1.7.7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] of_mmc_spi: fix little endian support
2012-01-30 4:15 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2012-01-30 13:14 ` Grant Likely
-1 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2012-01-30 13:14 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: linux-arm-kernel, linux-mmc
On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> the voltage_ranges is supposed to switch from big endian to little endian
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: linux-mmc@vger.kernel.org
Applied, thanks.
g.
> ---
> drivers/mmc/host/of_mmc_spi.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index ab66f24..ede2c64 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -109,12 +109,13 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
> goto err_ocr;
> }
>
> +
> for (i = 0; i < num_ranges; i++) {
> const int j = i * 2;
> u32 mask;
>
> - mask = mmc_vddrange_to_ocrmask(voltage_ranges[j],
> - voltage_ranges[j + 1]);
> + mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
> + be32_to_cpu(voltage_ranges[j + 1]));
> if (!mask) {
> ret = -EINVAL;
> dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
> --
> 1.7.7
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] of_mmc_spi: fix little endian support
@ 2012-01-30 13:14 ` Grant Likely
0 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2012-01-30 13:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> the voltage_ranges is supposed to switch from big endian to little endian
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: linux-mmc at vger.kernel.org
Applied, thanks.
g.
> ---
> drivers/mmc/host/of_mmc_spi.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index ab66f24..ede2c64 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -109,12 +109,13 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
> goto err_ocr;
> }
>
> +
> for (i = 0; i < num_ranges; i++) {
> const int j = i * 2;
> u32 mask;
>
> - mask = mmc_vddrange_to_ocrmask(voltage_ranges[j],
> - voltage_ranges[j + 1]);
> + mask = mmc_vddrange_to_ocrmask(be32_to_cpu(voltage_ranges[j]),
> + be32_to_cpu(voltage_ranges[j + 1]));
> if (!mask) {
> ret = -EINVAL;
> dev_err(dev, "OF: voltage-range #%d is invalid\n", i);
> --
> 1.7.7
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] of_mmc_spi: fix little endian support
2012-01-30 13:14 ` Grant Likely
@ 2012-01-30 15:18 ` Grant Likely
-1 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2012-01-30 15:18 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: linux-arm-kernel, linux-mmc, Chris Ball
On Mon, Jan 30, 2012 at 6:14 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> the voltage_ranges is supposed to switch from big endian to little endian
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: linux-mmc@vger.kernel.org
>
> Applied, thanks.
Actually, this one should go via Chris' tree since it is part of
drivers/mmc. So I've dropped it from my tree and change that s-o-b of
mine to an a-b.
g.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] of_mmc_spi: fix little endian support
@ 2012-01-30 15:18 ` Grant Likely
0 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2012-01-30 15:18 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 30, 2012 at 6:14 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> the voltage_ranges is supposed to switch from big endian to little endian
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: linux-mmc at vger.kernel.org
>
> Applied, thanks.
Actually, this one should go via Chris' tree since it is part of
drivers/mmc. So I've dropped it from my tree and change that s-o-b of
mine to an a-b.
g.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] of_mmc_spi: fix little endian support
2012-01-30 15:18 ` Grant Likely
@ 2012-01-30 15:30 ` Chris Ball
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Ball @ 2012-01-30 15:30 UTC (permalink / raw)
To: Grant Likely
Cc: Jean-Christophe PLAGNIOL-VILLARD, linux-arm-kernel, linux-mmc
Hi,
On Mon, Jan 30 2012, Grant Likely wrote:
> On Mon, Jan 30, 2012 at 6:14 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
>> On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe
>> PLAGNIOL-VILLARD wrote:
>>> the voltage_ranges is supposed to switch from big endian to little endian
>>>
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: linux-mmc@vger.kernel.org
>>
>> Applied, thanks.
>
> Actually, this one should go via Chris' tree since it is part of
> drivers/mmc. So I've dropped it from my tree and change that s-o-b of
> mine to an a-b.
Thanks, done that, and removed the extra/incorrect punctuation change
from the patch.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] of_mmc_spi: fix little endian support
@ 2012-01-30 15:30 ` Chris Ball
0 siblings, 0 replies; 8+ messages in thread
From: Chris Ball @ 2012-01-30 15:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Jan 30 2012, Grant Likely wrote:
> On Mon, Jan 30, 2012 at 6:14 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
>> On Mon, Jan 30, 2012 at 05:15:29AM +0100, Jean-Christophe
>> PLAGNIOL-VILLARD wrote:
>>> the voltage_ranges is supposed to switch from big endian to little endian
>>>
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: linux-mmc at vger.kernel.org
>>
>> Applied, thanks.
>
> Actually, this one should go via Chris' tree since it is part of
> drivers/mmc. So I've dropped it from my tree and change that s-o-b of
> mine to an a-b.
Thanks, done that, and removed the extra/incorrect punctuation change
from the patch.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-01-30 15:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 4:15 [PATCH 1/1] of_mmc_spi: fix little endian support Jean-Christophe PLAGNIOL-VILLARD
2012-01-30 4:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-30 13:14 ` Grant Likely
2012-01-30 13:14 ` Grant Likely
2012-01-30 15:18 ` Grant Likely
2012-01-30 15:18 ` Grant Likely
2012-01-30 15:30 ` Chris Ball
2012-01-30 15:30 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.