From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2] mmc: sdio: fix alignment issue in struct sdio_func
Date: Wed, 29 Mar 2017 15:58:10 -0700 [thread overview]
Message-ID: <m24lyb667x.fsf@baylibre.com> (raw)
In-Reply-To: <3a6258f3-35e3-e2f5-aa6b-e509f603fa45@gmail.com> (Heiner Kallweit's message of "Wed, 29 Mar 2017 22:56:50 +0200")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be
> used for DMA to be 8-byte-aligned. struct sdio_func has an embedded
> small DMA buffer not meeting this requirement.
> Testing an extension to meson-gx driver for switching to descriptor
> chain mode broke SDIO therefore. Aligning tmpbuf to a 8-byte
> boundary fixed the driver behavior.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Tested-by: Helmut Klein <hgkr.klein@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-amlogic@lists.infradead.org,
Helmut Klein <hgkr.klein@gmail.com>
Subject: Re: [PATCH v2] mmc: sdio: fix alignment issue in struct sdio_func
Date: Wed, 29 Mar 2017 15:58:10 -0700 [thread overview]
Message-ID: <m24lyb667x.fsf@baylibre.com> (raw)
In-Reply-To: <3a6258f3-35e3-e2f5-aa6b-e509f603fa45@gmail.com> (Heiner Kallweit's message of "Wed, 29 Mar 2017 22:56:50 +0200")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be
> used for DMA to be 8-byte-aligned. struct sdio_func has an embedded
> small DMA buffer not meeting this requirement.
> Testing an extension to meson-gx driver for switching to descriptor
> chain mode broke SDIO therefore. Aligning tmpbuf to a 8-byte
> boundary fixed the driver behavior.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Tested-by: Helmut Klein <hgkr.klein@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Kevin
next prev parent reply other threads:[~2017-03-29 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 20:56 [PATCH v2] mmc: sdio: fix alignment issue in struct sdio_func Heiner Kallweit
2017-03-29 20:56 ` Heiner Kallweit
2017-03-29 22:58 ` Kevin Hilman [this message]
2017-03-29 22:58 ` Kevin Hilman
2017-04-13 20:54 ` Heiner Kallweit
2017-04-13 20:54 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24lyb667x.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.