All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/3] mmc: meson-gx: minor improvements in meson_mmc_set_ios
Date: Fri, 27 Jan 2017 09:43:45 -0800	[thread overview]
Message-ID: <m24m0kwg8e.fsf@baylibre.com> (raw)
In-Reply-To: <4ec4f0af-c5c9-955c-6158-8c38aa61b358@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 22:50:25 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> val isn't used in the switch clause and afterwards there's an
> identical statement. So remove it.
>
> In case of an unexpected bus width the error message indicates
> the intention to set the bus width to 4 and to go on.
> So remove the return statement. This return statement also
> conflicts with "setting to 4" because nothing would be set
> actually before returning.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

Thanks for the fix,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mmc: meson-gx: minor improvements in meson_mmc_set_ios
Date: Fri, 27 Jan 2017 09:43:45 -0800	[thread overview]
Message-ID: <m24m0kwg8e.fsf@baylibre.com> (raw)
In-Reply-To: <4ec4f0af-c5c9-955c-6158-8c38aa61b358@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 22:50:25 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> val isn't used in the switch clause and afterwards there's an
> identical statement. So remove it.
>
> In case of an unexpected bus width the error message indicates
> the intention to set the bus width to 4 and to go on.
> So remove the return statement. This return statement also
> conflicts with "setting to 4" because nothing would be set
> actually before returning.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

Thanks for the fix,

Kevin

  reply	other threads:[~2017-01-27 17:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 21:50 [PATCH 2/3] mmc: meson-gx: minor improvements in meson_mmc_set_ios Heiner Kallweit
2017-01-26 21:50 ` Heiner Kallweit
2017-01-27 17:43 ` Kevin Hilman [this message]
2017-01-27 17:43   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m24m0kwg8e.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.