From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 7/7] arm64: dts: gxbb clock controller
Date: Tue, 14 Jun 2016 12:01:26 -0700 [thread overview]
Message-ID: <m260tbsigp.fsf@baylibre.com> (raw)
In-Reply-To: <1465518774-26924-8-git-send-email-mturquette@baylibre.com> (Michael Turquette's message of "Thu, 9 Jun 2016 17:32:54 -0700")
Michael Turquette <mturquette@baylibre.com> writes:
> Add the clock controller node for the AmLogic GXBB machine.
>
> Signed-off-by: Michael Turquette <mturquette@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 832815d..3badfab 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -174,5 +174,12 @@
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>;
> };
> +
> + clkc: clock-controller at c883c000 {
> + compatible = "amlogic,gxbb-clkc";
> + #clock-cells = <1>;
> + reg = <0x0 0xc883c000 0x0 0x3db>;
> + };
> +
> };
> };
minor nit: could you put this under the (recently added) hibus node (at
offset 0). See the DT in my for-next branch for reference:
https://git.kernel.org/cgit/linux/kernel/git/khilman/linux-amlogic.git/log/?h=for-next
Thanks,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org,
carlo@endlessm.com, victor.wan@amlogic.com,
jerry.cao@amlogic.com, xing.xu@amlogic.com
Subject: Re: [PATCH 7/7] arm64: dts: gxbb clock controller
Date: Tue, 14 Jun 2016 12:01:26 -0700 [thread overview]
Message-ID: <m260tbsigp.fsf@baylibre.com> (raw)
In-Reply-To: <1465518774-26924-8-git-send-email-mturquette@baylibre.com> (Michael Turquette's message of "Thu, 9 Jun 2016 17:32:54 -0700")
Michael Turquette <mturquette@baylibre.com> writes:
> Add the clock controller node for the AmLogic GXBB machine.
>
> Signed-off-by: Michael Turquette <mturquette@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 832815d..3badfab 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -174,5 +174,12 @@
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>;
> };
> +
> + clkc: clock-controller@c883c000 {
> + compatible = "amlogic,gxbb-clkc";
> + #clock-cells = <1>;
> + reg = <0x0 0xc883c000 0x0 0x3db>;
> + };
> +
> };
> };
minor nit: could you put this under the (recently added) hibus node (at
offset 0). See the DT in my for-next branch for reference:
https://git.kernel.org/cgit/linux/kernel/git/khilman/linux-amlogic.git/log/?h=for-next
Thanks,
Kevin
next prev parent reply other threads:[~2016-06-14 19:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 0:32 [PATCH 0/7] Add support for AmLogic GXBB clock controller Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 1/7] clk: meson: add peripheral gate macro Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 2/7] clk: meson: add mpll support Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 3/7] clk: meson: fractional pll support Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 4/7] clk: gxbb: Document bindings for the GXBB clock controller Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 5/7] clk: gxbb: add AmLogic GXBB clk controller driver Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 6/7] arm64: amlogic: select gxbb clk driver Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-10 0:32 ` [PATCH 7/7] arm64: dts: gxbb clock controller Michael Turquette
2016-06-10 0:32 ` Michael Turquette
2016-06-14 19:01 ` Kevin Hilman [this message]
2016-06-14 19:01 ` Kevin Hilman
2016-06-15 1:41 ` Michael Turquette
2016-06-15 1:41 ` Michael Turquette
2016-06-10 9:12 ` [PATCH 0/7] Add support for AmLogic GXBB " Neil Armstrong
2016-06-13 17:55 ` Kevin Hilman
2016-06-14 5:02 ` Neil Armstrong
2016-06-14 18:59 ` Kevin Hilman
2016-06-14 18:59 ` Kevin Hilman
2016-06-15 1:41 ` Michael Turquette
2016-06-15 1:41 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260tbsigp.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.