From: Andi Kleen <andi@firstfloor.org>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: gregkh@linuxfoundation.org, kay@vrfy.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mike Turquette <mturquette@linaro.org>,
Vimarsh Zutshi <vimarsh.zutshi@gmail.com>
Subject: Re: [PATCH v3] printk: add option to print cpu id
Date: Fri, 03 Aug 2012 10:54:27 -0700 [thread overview]
Message-ID: <m2628z6euk.fsf@firstfloor.org> (raw)
In-Reply-To: <1344013004-32211-1-git-send-email-vikram.pandita@ti.com> (Vikram Pandita's message of "Fri, 3 Aug 2012 09:56:44 -0700")
Vikram Pandita <vikram.pandita@ti.com> writes:
> From: Vikram Pandita <vikram.pandita@ti.com>
>
> Introduce config option to enable CPU id reporting for printk() calls.
What's wrong with using trace_printk for this? That's much faster
anyways. Generally printk is so slow that it's typically useless for
instrumenting races.
And really: Wasting 1/3 of the 80 character line is too much.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
WARNING: multiple messages have this Message-ID (diff)
From: andi@firstfloor.org (Andi Kleen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] printk: add option to print cpu id
Date: Fri, 03 Aug 2012 10:54:27 -0700 [thread overview]
Message-ID: <m2628z6euk.fsf@firstfloor.org> (raw)
In-Reply-To: <1344013004-32211-1-git-send-email-vikram.pandita@ti.com> (Vikram Pandita's message of "Fri, 3 Aug 2012 09:56:44 -0700")
Vikram Pandita <vikram.pandita@ti.com> writes:
> From: Vikram Pandita <vikram.pandita@ti.com>
>
> Introduce config option to enable CPU id reporting for printk() calls.
What's wrong with using trace_printk for this? That's much faster
anyways. Generally printk is so slow that it's typically useless for
instrumenting races.
And really: Wasting 1/3 of the 80 character line is too much.
-Andi
--
ak at linux.intel.com -- Speaking for myself only
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Vikram Pandita <vikram.pandita@ti.com>
Cc: <gregkh@linuxfoundation.org>, <kay@vrfy.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Mike Turquette <mturquette@linaro.org>,
Vimarsh Zutshi <vimarsh.zutshi@gmail.com>
Subject: Re: [PATCH v3] printk: add option to print cpu id
Date: Fri, 03 Aug 2012 10:54:27 -0700 [thread overview]
Message-ID: <m2628z6euk.fsf@firstfloor.org> (raw)
In-Reply-To: <1344013004-32211-1-git-send-email-vikram.pandita@ti.com> (Vikram Pandita's message of "Fri, 3 Aug 2012 09:56:44 -0700")
Vikram Pandita <vikram.pandita@ti.com> writes:
> From: Vikram Pandita <vikram.pandita@ti.com>
>
> Introduce config option to enable CPU id reporting for printk() calls.
What's wrong with using trace_printk for this? That's much faster
anyways. Generally printk is so slow that it's typically useless for
instrumenting races.
And really: Wasting 1/3 of the 80 character line is too much.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-08-03 17:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 16:56 [PATCH v3] printk: add option to print cpu id Vikram Pandita
2012-08-03 16:56 ` Vikram Pandita
2012-08-03 16:56 ` Vikram Pandita
2012-08-03 17:54 ` Andi Kleen [this message]
2012-08-03 17:54 ` Andi Kleen
2012-08-03 17:54 ` Andi Kleen
2012-08-03 18:25 ` Pandita, Vikram
2012-08-03 18:25 ` Pandita, Vikram
2012-08-03 20:08 ` Aaro Koskinen
2012-08-03 20:08 ` Aaro Koskinen
2012-08-03 21:24 ` Pandita, Vikram
2012-08-03 21:24 ` Pandita, Vikram
2012-08-03 21:59 ` Greg KH
2012-08-03 21:59 ` Greg KH
2012-08-03 22:07 ` Pandita, Vikram
2012-08-03 22:07 ` Pandita, Vikram
2012-08-03 22:07 ` Pandita, Vikram
2012-08-03 22:13 ` Greg KH
2012-08-03 22:13 ` Greg KH
2012-08-03 22:25 ` Pandita, Vikram
2012-08-03 22:25 ` Pandita, Vikram
2012-08-03 22:36 ` Greg KH
2012-08-03 22:36 ` Greg KH
2012-08-03 22:48 ` Pandita, Vikram
2012-08-03 22:48 ` Pandita, Vikram
2012-08-06 13:39 ` Steven Rostedt
2012-08-06 13:39 ` Steven Rostedt
2012-08-04 8:51 ` Russell King - ARM Linux
2012-08-04 8:51 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2628z6euk.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=vikram.pandita@ti.com \
--cc=vimarsh.zutshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.