From: Andi Kleen <andi@firstfloor.org>
To: Jack Steiner <steiner@sgi.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] - Improve drain pages performance on large systems
Date: Tue, 15 Feb 2011 16:17:44 -0800 [thread overview]
Message-ID: <m262skx26v.fsf@firstfloor.org> (raw)
In-Reply-To: <20110215223840.GA27420@sgi.com> (Jack Steiner's message of "Tue, 15 Feb 2011 16:38:40 -0600")
Jack Steiner <steiner@sgi.com> writes:
> Heavy swapping within a cpuset causes frequent calls to drain_all_pages().
I suspect drain_all_pages should be really made more zone aware in the
first place and only drain what is actually needed (e.g.
work off a zonelist). I was fighting with this for hwpoison too.
That said your patch looks reasonable.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Jack Steiner <steiner@sgi.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] - Improve drain pages performance on large systems
Date: Tue, 15 Feb 2011 16:17:44 -0800 [thread overview]
Message-ID: <m262skx26v.fsf@firstfloor.org> (raw)
In-Reply-To: <20110215223840.GA27420@sgi.com> (Jack Steiner's message of "Tue, 15 Feb 2011 16:38:40 -0600")
Jack Steiner <steiner@sgi.com> writes:
> Heavy swapping within a cpuset causes frequent calls to drain_all_pages().
I suspect drain_all_pages should be really made more zone aware in the
first place and only drain what is actually needed (e.g.
work off a zonelist). I was fighting with this for hwpoison too.
That said your patch looks reasonable.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-21 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 22:38 [PATCH] - Improve drain pages performance on large systems Jack Steiner
2011-02-15 22:38 ` Jack Steiner
2011-02-16 0:00 ` Minchan Kim
2011-02-16 0:00 ` Minchan Kim
2011-02-16 3:01 ` David Rientjes
2011-02-16 3:01 ` David Rientjes
2011-02-16 15:43 ` Jack Steiner
2011-02-16 15:43 ` Jack Steiner
2011-02-16 0:17 ` Andi Kleen [this message]
2011-02-16 0:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m262skx26v.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.