All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT
Date: Tue, 28 Mar 2017 07:57:40 -0700	[thread overview]
Message-ID: <m27f39bg9n.fsf@baylibre.com> (raw)
In-Reply-To: <c575d8e4-05ca-8eb0-8b64-24a65a5711a7@baylibre.com> (Neil Armstrong's message of "Tue, 28 Mar 2017 11:38:20 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 03/28/2017 11:30 AM, Linus Walleij wrote:
>> On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> 
>> '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
>>> is needed when gpiochip_add_data() is called but in the current implementation
>>> the ranges are added from the driver afterwards.
>>>
>>> A simple solution is to rely on the DR gpio-ranges attribute and remove the
>>> call to gpiochip_add_pin_range().
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This is fine once the ranges have been applied to the device trees I guess.
>> 
>> Tell me when you want me to merge this.
>> 
>> Yours,
>> Linus Walleij
>> 
>
> Hi Linus,
>
> Kevin should merge the DT patches since they have now Tested and Reviewed by's, so you can merge it now if you can.
> Since it will live in you pinctrl tree, it will only impact linux-next until Kevin merges them.

I've applied the DT patches now (branch: v4.12/dt64)

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Carlo Caione <carlo@caione.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT
Date: Tue, 28 Mar 2017 07:57:40 -0700	[thread overview]
Message-ID: <m27f39bg9n.fsf@baylibre.com> (raw)
In-Reply-To: <c575d8e4-05ca-8eb0-8b64-24a65a5711a7@baylibre.com> (Neil Armstrong's message of "Tue, 28 Mar 2017 11:38:20 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 03/28/2017 11:30 AM, Linus Walleij wrote:
>> On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> 
>> '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
>>> is needed when gpiochip_add_data() is called but in the current implementation
>>> the ranges are added from the driver afterwards.
>>>
>>> A simple solution is to rely on the DR gpio-ranges attribute and remove the
>>> call to gpiochip_add_pin_range().
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This is fine once the ranges have been applied to the device trees I guess.
>> 
>> Tell me when you want me to merge this.
>> 
>> Yours,
>> Linus Walleij
>> 
>
> Hi Linus,
>
> Kevin should merge the DT patches since they have now Tested and Reviewed by's, so you can merge it now if you can.
> Since it will live in you pinctrl tree, it will only impact linux-next until Kevin merges them.

I've applied the DT patches now (branch: v4.12/dt64)

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT
Date: Tue, 28 Mar 2017 07:57:40 -0700	[thread overview]
Message-ID: <m27f39bg9n.fsf@baylibre.com> (raw)
In-Reply-To: <c575d8e4-05ca-8eb0-8b64-24a65a5711a7@baylibre.com> (Neil Armstrong's message of "Tue, 28 Mar 2017 11:38:20 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 03/28/2017 11:30 AM, Linus Walleij wrote:
>> On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> 
>> '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
>>> is needed when gpiochip_add_data() is called but in the current implementation
>>> the ranges are added from the driver afterwards.
>>>
>>> A simple solution is to rely on the DR gpio-ranges attribute and remove the
>>> call to gpiochip_add_pin_range().
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This is fine once the ranges have been applied to the device trees I guess.
>> 
>> Tell me when you want me to merge this.
>> 
>> Yours,
>> Linus Walleij
>> 
>
> Hi Linus,
>
> Kevin should merge the DT patches since they have now Tested and Reviewed by's, so you can merge it now if you can.
> Since it will live in you pinctrl tree, it will only impact linux-next until Kevin merges them.

I've applied the DT patches now (branch: v4.12/dt64)

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Carlo Caione <carlo@caione.org>,
	"open list\:ARM\/Amlogic Meson..." 
	<linux-amlogic@lists.infradead.org>,
	"linux-gpio\@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT
Date: Tue, 28 Mar 2017 07:57:40 -0700	[thread overview]
Message-ID: <m27f39bg9n.fsf@baylibre.com> (raw)
In-Reply-To: <c575d8e4-05ca-8eb0-8b64-24a65a5711a7@baylibre.com> (Neil Armstrong's message of "Tue, 28 Mar 2017 11:38:20 +0200")

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 03/28/2017 11:30 AM, Linus Walleij wrote:
>> On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> 
>> '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges
>>> is needed when gpiochip_add_data() is called but in the current implementation
>>> the ranges are added from the driver afterwards.
>>>
>>> A simple solution is to rely on the DR gpio-ranges attribute and remove the
>>> call to gpiochip_add_pin_range().
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> 
>> This is fine once the ranges have been applied to the device trees I guess.
>> 
>> Tell me when you want me to merge this.
>> 
>> Yours,
>> Linus Walleij
>> 
>
> Hi Linus,
>
> Kevin should merge the DT patches since they have now Tested and Reviewed by's, so you can merge it now if you can.
> Since it will live in you pinctrl tree, it will only impact linux-next until Kevin merges them.

I've applied the DT patches now (branch: v4.12/dt64)

Kevin

  reply	other threads:[~2017-03-28 14:57 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 16:27 [RFT PATCH 0/6] pinctrl: meson: Fix gpio-ranged for GPIO Hog Neil Armstrong
2017-03-23 16:27 ` Neil Armstrong
2017-03-23 16:27 ` Neil Armstrong
2017-03-23 16:27 ` [RFT PATCH 1/6] ARM64: dts: meson-gxbb: Add gpio-ranges properties Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-28  9:28   ` Linus Walleij
2017-03-28  9:28     ` Linus Walleij
2017-03-28  9:28     ` Linus Walleij
2017-03-28  9:28     ` Linus Walleij
2017-03-23 16:27 ` [RFT PATCH 2/6] ARM64: dts: meson-gxl: " Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-28  9:28   ` Linus Walleij
2017-03-28  9:28     ` Linus Walleij
2017-03-28  9:28     ` Linus Walleij
2017-03-23 16:27 ` [RFT PATCH 3/6] ARM: dts: meson8: " Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-28  9:29   ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-23 16:27 ` [RFT PATCH 4/6] ARM: dts: meson8b: " Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-28  9:29   ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-28  9:29     ` Linus Walleij
2017-03-23 16:27 ` [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 20:09   ` Martin Blumenstingl
2017-03-23 20:09     ` Martin Blumenstingl
2017-03-23 20:09     ` Martin Blumenstingl
2017-03-23 20:09     ` Martin Blumenstingl
2017-03-24 16:52     ` Neil Armstrong
2017-03-24 16:52       ` Neil Armstrong
2017-03-24 16:52       ` Neil Armstrong
2017-03-28  9:30   ` Linus Walleij
2017-03-28  9:30     ` Linus Walleij
2017-03-28  9:30     ` Linus Walleij
2017-03-28  9:30     ` Linus Walleij
2017-03-28  9:38     ` Neil Armstrong
2017-03-28  9:38       ` Neil Armstrong
2017-03-28  9:38       ` Neil Armstrong
2017-03-28 14:57       ` Kevin Hilman [this message]
2017-03-28 14:57         ` Kevin Hilman
2017-03-28 14:57         ` Kevin Hilman
2017-03-28 14:57         ` Kevin Hilman
2017-03-28  9:40   ` Linus Walleij
2017-03-28  9:40     ` Linus Walleij
2017-03-28  9:40     ` Linus Walleij
2017-03-28  9:40     ` Linus Walleij
2017-03-23 16:27 ` [RFT PATCH 6/6] ARM64: dts: meson-gxbb: Add USB Hub GPIO hog Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-23 16:27   ` Neil Armstrong
2017-03-28  9:31   ` Linus Walleij
2017-03-28  9:31     ` Linus Walleij
2017-03-28  9:31     ` Linus Walleij
2017-03-24 20:11 ` [RFT PATCH 0/6] pinctrl: meson: Fix gpio-ranged for GPIO Hog Kevin Hilman
2017-03-24 20:11   ` Kevin Hilman
2017-03-24 20:11   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m27f39bg9n.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.