All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Edmondson <david.edmondson@oracle.com>
To: Parav Pandit <parav@nvidia.com>,
	mst@redhat.com, virtio-dev@lists.oasis-open.org,
	cohuck@redhat.com
Cc: sgarzare@redhat.com, pasic@linux.ibm.com,
	virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] Re: [PATCH v16 01/11] content: Add vq index text
Date: Thu, 04 May 2023 15:20:13 +0100	[thread overview]
Message-ID: <m28re45gbm.fsf@oracle.com> (raw)
In-Reply-To: <20230504022959.547025-2-parav@nvidia.com>

Parav Pandit <parav@nvidia.com> writes:

> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
> changelog:
> v15->v16:
> - rewrote for better reading
> v12->v13:
> - avoid virtqueue -> vq abbreviation
> - removed Cornelia's reviewed-by due to vq abbreviation change
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
>   prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
>   queue data transfer description
> v2->v3:
> - new patch
> ---
>  content.tex | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..9b694f2 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,10 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
>  virtqueues\footnote{For example, the simplest network device has one virtqueue for
>  transmit and one for receive.}.
>  
> +A virtio device can have maximum of 65536 virtqueues. Each virtqueue is
> +identified by a virtqueue index. A virtqueue index has a value in the
> +range of 0 to 65535.
> +
>  Driver makes requests available to device by adding
>  an available buffer to the queue, i.e., adding a buffer
>  describing the request to a virtqueue, and optionally triggering
> -- 
> 2.26.2
-- 
Walking upside down in the sky, between the satellites passing by, I'm looking.

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: David Edmondson <david.edmondson@oracle.com>
To: Parav Pandit <parav@nvidia.com>,
	mst@redhat.com, virtio-dev@lists.oasis-open.org,
	cohuck@redhat.com
Cc: sgarzare@redhat.com, pasic@linux.ibm.com,
	virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
	Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] Re: [PATCH v16 01/11] content: Add vq index text
Date: Thu, 04 May 2023 15:20:13 +0100	[thread overview]
Message-ID: <m28re45gbm.fsf@oracle.com> (raw)
In-Reply-To: <20230504022959.547025-2-parav@nvidia.com>

Parav Pandit <parav@nvidia.com> writes:

> Introduce vq index and its range so that subsequent patches can refer
> to it.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
> changelog:
> v15->v16:
> - rewrote for better reading
> v12->v13:
> - avoid virtqueue -> vq abbreviation
> - removed Cornelia's reviewed-by due to vq abbreviation change
> v11->v12:
> - renamed 'number' to 'index'
> v9->v10:
> - added braces around vq number wording
> - added vqn as another term for vq number
> v8->v9:
> - added inclusive when describing the vq number range
> - skipped comment to put virtqueue number wording first because we
>   prefer to use shorter vq number as much as possible
> v5->v6:
> - moved description close to introduction, it was in middle of
>   queue data transfer description
> v2->v3:
> - new patch
> ---
>  content.tex | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/content.tex b/content.tex
> index cff548a..9b694f2 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -298,6 +298,10 @@ \section{Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Virtqueues}
>  virtqueues\footnote{For example, the simplest network device has one virtqueue for
>  transmit and one for receive.}.
>  
> +A virtio device can have maximum of 65536 virtqueues. Each virtqueue is
> +identified by a virtqueue index. A virtqueue index has a value in the
> +range of 0 to 65535.
> +
>  Driver makes requests available to device by adding
>  an available buffer to the queue, i.e., adding a buffer
>  describing the request to a virtqueue, and optionally triggering
> -- 
> 2.26.2
-- 
Walking upside down in the sky, between the satellites passing by, I'm looking.

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-05-04 14:25 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04  2:29 [virtio-comment] [PATCH v16 00/11] Rename queue number to queue index Parav Pandit
2023-05-04  2:29 ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 01/11] content: Add vq index text Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:20   ` David Edmondson [this message]
2023-05-04 14:20     ` [virtio-dev] " David Edmondson
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:20   ` [virtio-comment] " David Edmondson
2023-05-04 14:20     ` [virtio-dev] " David Edmondson
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:28   ` [virtio-comment] " David Edmondson
2023-05-04 14:28     ` [virtio-dev] " David Edmondson
2023-05-04 18:33     ` [virtio-comment] " Parav Pandit
2023-05-04 18:33       ` [virtio-dev] " Parav Pandit
2023-05-04 18:49       ` [virtio-comment] " Michael S. Tsirkin
2023-05-04 18:49         ` [virtio-dev] " Michael S. Tsirkin
2023-05-04 19:00         ` [virtio-comment] " Parav Pandit
2023-05-04 19:00           ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:28   ` [virtio-comment] " David Edmondson
2023-05-04 14:28     ` [virtio-dev] " David Edmondson
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 06/11] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:29   ` [virtio-comment] " David Edmondson
2023-05-04 14:29     ` [virtio-dev] " David Edmondson
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 07/11] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 09/11] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:30   ` [virtio-comment] " David Edmondson
2023-05-04 14:30     ` [virtio-dev] " David Edmondson
2023-05-04  2:29 ` [virtio-comment] [PATCH v16 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
2023-05-04  2:29   ` [virtio-dev] " Parav Pandit
2023-05-04 14:31   ` [virtio-comment] " David Edmondson
2023-05-04 14:31     ` [virtio-dev] " David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28re45gbm.fsf@oracle.com \
    --to=david.edmondson@oracle.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.