From: Andreas Schwab <schwab@linux-m68k.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
Date: Thu, 30 May 2013 09:09:38 +0200 [thread overview]
Message-ID: <m2a9ndndu5.fsf@linux-m68k.org> (raw)
In-Reply-To: <51A6F0C6.9050806@asianux.com> (Chen Gang's message of "Thu, 30 May 2013 14:25:10 +0800")
Chen Gang <gang.chen@asianux.com> writes:
> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
> author wanted to check the highest bit whether set.
>
> So need type cast form 'unsigned long' to 'long'.
Better to make the bit test explicit, since it is not a sign bit.
> diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
> index 08f286d..ef013c5 100644
> --- a/arch/m68k/math-emu/fp_arith.c
> +++ b/arch/m68k/math-emu/fp_arith.c
> @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
> return;
> break;
> case 0x401e:
> - if (!(oldmant.m32[1] >= 0))
> + if (!((long)oldmant.m32[1] >= 0))
if (oldmant.m32[1] & 0x80000000)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero.
Date: Thu, 30 May 2013 09:09:38 +0200 [thread overview]
Message-ID: <m2a9ndndu5.fsf@linux-m68k.org> (raw)
In-Reply-To: <51A6F0C6.9050806@asianux.com> (Chen Gang's message of "Thu, 30 May 2013 14:25:10 +0800")
Chen Gang <gang.chen@asianux.com> writes:
> 'oldmant.m32[1]' is 'unsigned long' which never '< 0', and the original
> author wanted to check the highest bit whether set.
>
> So need type cast form 'unsigned long' to 'long'.
Better to make the bit test explicit, since it is not a sign bit.
> diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c
> index 08f286d..ef013c5 100644
> --- a/arch/m68k/math-emu/fp_arith.c
> +++ b/arch/m68k/math-emu/fp_arith.c
> @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
> return;
> break;
> case 0x401e:
> - if (!(oldmant.m32[1] >= 0))
> + if (!((long)oldmant.m32[1] >= 0))
if (oldmant.m32[1] & 0x80000000)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-05-30 7:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 6:25 [PATCH] arch: m68k: math-emu: unsigned issue, 'unsigned long' will never be less than zero Chen Gang
2013-05-30 6:25 ` Chen Gang
2013-05-30 7:09 ` Andreas Schwab [this message]
2013-05-30 7:09 ` Andreas Schwab
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:08 ` Chen Gang
2013-05-30 8:21 ` [PATCH v2] " Chen Gang
2013-05-30 8:21 ` Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
2013-05-31 9:12 ` Geert Uytterhoeven
2013-06-03 9:10 ` Chen Gang
2013-06-03 9:10 ` Chen Gang
2013-06-03 9:10 ` Chen Gang
2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:13 ` Geert Uytterhoeven
2013-06-03 9:22 ` Chen Gang
2013-06-03 9:22 ` Chen Gang
2013-06-03 9:22 ` Chen Gang
2013-05-31 9:12 ` Geert Uytterhoeven
2013-05-30 7:09 ` [PATCH] " Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2013-05-30 6:25 Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a9ndndu5.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gang.chen@asianux.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.