All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Kenny <darren.kenny@oracle.com>
To: Jagannathan Raman <jag.raman@oracle.com>, grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, alec.r.brown@oracle.com
Subject: Re: GRUB coverity fixes for CIDs 314020 and 314023
Date: Fri, 03 Jun 2022 14:12:00 +0100	[thread overview]
Message-ID: <m2czfp99i7.fsf@oracle.com> (raw)
In-Reply-To: <cover.1654182611.git.jag.raman@oracle.com>

On Thursday, 2022-06-02 at 15:18:25 UTC, Jagannathan Raman wrote:
> Hi,
>
> This series addresses a couple of untrusted loop bounds flagged by
> Coverity in "grub-core/fs/zfs". Both the bugs addressed in this series
> are of the same type - caused by downcast of pointer from a strict type
> to a less strict type.
>
> Please share your thoughts on this.
>

These changes look good to me, thanks for looking at them Jag.

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

Thanks,

Darren.

> Thank you!
> --
> Jag
>
> Jagannathan Raman (2):
>   fs/zfs/zfs.c: make_mdn() - avoid pointer downcasting
>   fs/zfs/zfs.c: zfs_mount() - avoid pointer downcasting
>
>  grub-core/fs/zfs/zfs.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
>
> -- 
> 2.31.1


  parent reply	other threads:[~2022-06-03 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 15:18 GRUB coverity fixes for CIDs 314020 and 314023 Jagannathan Raman
2022-06-02 15:18 ` [PATCH 1/2] fs/zfs/zfs.c: make_mdn() - avoid pointer downcasting Jagannathan Raman
2022-06-02 15:18 ` [PATCH 2/2] fs/zfs/zfs.c: zfs_mount() " Jagannathan Raman
2022-06-03 13:12 ` Darren Kenny [this message]
2022-06-06 18:42   ` GRUB coverity fixes for CIDs 314020 and 314023 Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2czfp99i7.fsf@oracle.com \
    --to=darren.kenny@oracle.com \
    --cc=alec.r.brown@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=jag.raman@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.