All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins
Date: Thu, 08 Sep 2016 11:08:07 -0700	[thread overview]
Message-ID: <m2d1kenu2g.fsf@baylibre.com> (raw)
In-Reply-To: <1473261223-15412-2-git-send-email-jbrunet@baylibre.com> (Jerome Brunet's message of "Wed, 7 Sep 2016 17:13:37 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add EE domains pins for the SPI flash controller
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..802ad83 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -156,6 +156,11 @@ static const unsigned int emmc_clk_pins[] = { PIN(BOOT_8, EE_OFF) };
>  static const unsigned int emmc_cmd_pins[] = { PIN(BOOT_10, EE_OFF) };
>  static const unsigned int emmc_ds_pins[] = { PIN(BOOT_15, EE_OFF) };
>  
> +static const unsigned int spifc_d_pins[]	= { PIN(BOOT_11, EE_OFF) };
> +static const unsigned int spifc_q_pins[]	= { PIN(BOOT_12, EE_OFF) };
> +static const unsigned int spifc_c_pins[]	= { PIN(BOOT_13, EE_OFF) };
> +static const unsigned int spifc_cs_pins[]	= { PIN(BOOT_15, EE_OFF) };

In the datasheet, these are called nor_* instead of spifc_*.  I'm trying
to keep the names here aligned with the names in the datasheet.  Please
rename to nor_*.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Carlo Caione <carlo@caione.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins
Date: Thu, 08 Sep 2016 11:08:07 -0700	[thread overview]
Message-ID: <m2d1kenu2g.fsf@baylibre.com> (raw)
In-Reply-To: <1473261223-15412-2-git-send-email-jbrunet@baylibre.com> (Jerome Brunet's message of "Wed, 7 Sep 2016 17:13:37 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add EE domains pins for the SPI flash controller
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..802ad83 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -156,6 +156,11 @@ static const unsigned int emmc_clk_pins[] = { PIN(BOOT_8, EE_OFF) };
>  static const unsigned int emmc_cmd_pins[] = { PIN(BOOT_10, EE_OFF) };
>  static const unsigned int emmc_ds_pins[] = { PIN(BOOT_15, EE_OFF) };
>  
> +static const unsigned int spifc_d_pins[]	= { PIN(BOOT_11, EE_OFF) };
> +static const unsigned int spifc_q_pins[]	= { PIN(BOOT_12, EE_OFF) };
> +static const unsigned int spifc_c_pins[]	= { PIN(BOOT_13, EE_OFF) };
> +static const unsigned int spifc_cs_pins[]	= { PIN(BOOT_15, EE_OFF) };

In the datasheet, these are called nor_* instead of spifc_*.  I'm trying
to keep the names here aligned with the names in the datasheet.  Please
rename to nor_*.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins
Date: Thu, 08 Sep 2016 11:08:07 -0700	[thread overview]
Message-ID: <m2d1kenu2g.fsf@baylibre.com> (raw)
In-Reply-To: <1473261223-15412-2-git-send-email-jbrunet@baylibre.com> (Jerome Brunet's message of "Wed, 7 Sep 2016 17:13:37 +0200")

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add EE domains pins for the SPI flash controller
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..802ad83 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -156,6 +156,11 @@ static const unsigned int emmc_clk_pins[] = { PIN(BOOT_8, EE_OFF) };
>  static const unsigned int emmc_cmd_pins[] = { PIN(BOOT_10, EE_OFF) };
>  static const unsigned int emmc_ds_pins[] = { PIN(BOOT_15, EE_OFF) };
>  
> +static const unsigned int spifc_d_pins[]	= { PIN(BOOT_11, EE_OFF) };
> +static const unsigned int spifc_q_pins[]	= { PIN(BOOT_12, EE_OFF) };
> +static const unsigned int spifc_c_pins[]	= { PIN(BOOT_13, EE_OFF) };
> +static const unsigned int spifc_cs_pins[]	= { PIN(BOOT_15, EE_OFF) };

In the datasheet, these are called nor_* instead of spifc_*.  I'm trying
to keep the names here aligned with the names in the datasheet.  Please
rename to nor_*.

Thanks,

Kevin

  reply	other threads:[~2016-09-08 18:08 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 15:13 [PATCH 0/7] ARM: amlogic: Add spifc support to Amlogic's GXBB family Jerome Brunet
2016-09-07 15:13 ` Jerome Brunet
2016-09-07 15:13 ` Jerome Brunet
2016-09-07 15:13 ` [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-08 18:08   ` Kevin Hilman [this message]
2016-09-08 18:08     ` Kevin Hilman
2016-09-08 18:08     ` Kevin Hilman
2016-09-07 15:13 ` [PATCH 2/7] pinctrl: amlogic: gxbb: add nand pins Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-08 18:09   ` Kevin Hilman
2016-09-08 18:09     ` Kevin Hilman
2016-09-08 18:09     ` Kevin Hilman
2016-09-07 15:13 ` [PATCH 3/7] clk: gxbb: expose spifc clock Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 21:27   ` Stephen Boyd
2016-09-07 21:27     ` Stephen Boyd
2016-09-07 21:27     ` Stephen Boyd
2016-09-08 18:12     ` Kevin Hilman
2016-09-08 18:12       ` Kevin Hilman
2016-09-08 18:12       ` Kevin Hilman
2016-09-08 18:12       ` Kevin Hilman
2016-09-07 15:13 ` [PATCH 4/7] spi: meson: Add GXBB compatible Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 18:58   ` Mark Brown
2016-09-07 18:58     ` Mark Brown
2016-09-07 18:58     ` Mark Brown
2016-09-07 18:58     ` Mark Brown
2016-09-08  7:44     ` Neil Armstrong
2016-09-08  7:44       ` Neil Armstrong
2016-09-08  7:44       ` Neil Armstrong
2016-09-12 19:12   ` Applied "spi: meson: Add GXBB compatible" to the spi tree Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-07 15:13 ` [PATCH 5/7] dt-bindings: spi-meson: Add GXBB Compatible string Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-12 19:12   ` Applied "spi: meson: Add GXBB Compatible string" to the spi tree Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-12 19:12     ` Mark Brown
2016-09-07 15:13 ` [PATCH 6/7] ARM64: dts: amlogic: add pins for spifc Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13 ` [PATCH 7/7] ARM64: dts: meson-gxbb: Add SPIFC node Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet
2016-09-07 15:13   ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d1kenu2g.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.