From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi.kleen@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Rik van Riel <riel@redhat.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
Naoya Horiguchi <nhoriguc@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean
Date: Fri, 10 Aug 2012 16:08:10 -0700 [thread overview]
Message-ID: <m2ehnecplx.fsf@firstfloor.org> (raw)
In-Reply-To: <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> (Naoya Horiguchi's message of "Fri, 10 Aug 2012 17:41:51 -0400")
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> writes:
> action_result() fails to print out "dirty" even if an error occurred on a
> dirty pagecache, because when we check PageDirty in action_result() it was
> cleared after page isolation even if it's dirty before error handling. This
> can break some applications that monitor this message, so should be fixed.
>
> There are several callers of action_result() except page_action(), but
> either of them are not for LRU pages but for free pages or kernel pages,
> so we don't have to consider dirty or not for them.
Looks good
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi.kleen@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Rik van Riel <riel@redhat.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
Naoya Horiguchi <nhoriguc@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean
Date: Fri, 10 Aug 2012 16:08:10 -0700 [thread overview]
Message-ID: <m2ehnecplx.fsf@firstfloor.org> (raw)
In-Reply-To: <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> (Naoya Horiguchi's message of "Fri, 10 Aug 2012 17:41:51 -0400")
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> writes:
> action_result() fails to print out "dirty" even if an error occurred on a
> dirty pagecache, because when we check PageDirty in action_result() it was
> cleared after page isolation even if it's dirty before error handling. This
> can break some applications that monitor this message, so should be fixed.
>
> There are several callers of action_result() except page_action(), but
> either of them are not for LRU pages but for free pages or kernel pages,
> so we don't have to consider dirty or not for them.
Looks good
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-08-10 23:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 21:41 [PATCH 0/3 v1] HWPOISON: improve dirty pagecache error handling Naoya Horiguchi
2012-08-10 21:41 ` Naoya Horiguchi
2012-08-10 21:41 ` [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean Naoya Horiguchi
2012-08-10 21:41 ` Naoya Horiguchi
2012-08-10 23:08 ` Andi Kleen [this message]
2012-08-10 23:08 ` Andi Kleen
2012-08-10 21:41 ` [PATCH 2/3] HWPOISON: undo memory error handling for dirty pagecache Naoya Horiguchi
2012-08-10 21:41 ` Naoya Horiguchi
2012-08-10 23:09 ` Andi Kleen
2012-08-10 23:09 ` Andi Kleen
2012-08-11 0:58 ` Naoya Horiguchi
2012-08-11 0:58 ` Naoya Horiguchi
2012-08-13 10:10 ` Jun'ichi Nomura
2012-08-13 10:10 ` Jun'ichi Nomura
2012-08-10 21:41 ` [PATCH 3/3] HWPOISON: improve handling/reporting of memory error on " Naoya Horiguchi
2012-08-10 21:41 ` Naoya Horiguchi
2012-08-10 22:01 ` Naoya Horiguchi
2012-08-10 22:01 ` Naoya Horiguchi
2012-08-10 23:13 ` Andi Kleen
2012-08-10 23:13 ` Andi Kleen
2012-08-11 1:01 ` Naoya Horiguchi
2012-08-11 1:01 ` Naoya Horiguchi
2012-08-11 11:15 ` Andi Kleen
2012-08-11 11:15 ` Andi Kleen
2012-08-11 21:14 ` Naoya Horiguchi
2012-08-11 21:14 ` Naoya Horiguchi
2012-08-12 3:28 ` Andi Kleen
2012-08-12 3:28 ` Andi Kleen
2012-08-12 15:19 ` Naoya Horiguchi
2012-08-12 15:19 ` Naoya Horiguchi
2012-08-11 22:41 ` Luck, Tony
2012-08-11 22:41 ` Luck, Tony
2012-08-12 15:57 ` Naoya Horiguchi
2012-08-12 15:57 ` Naoya Horiguchi
-- strict thread matches above, loose matches on Subject: below --
2012-08-22 15:17 [PATCH 0/3 v2] HWPOISON: improve dirty pagecache error reporting Naoya Horiguchi
2012-08-22 15:17 ` [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean Naoya Horiguchi
2012-08-22 15:17 ` Naoya Horiguchi
2012-08-23 9:33 ` Fengguang Wu
2012-08-23 9:33 ` Fengguang Wu
2012-08-23 20:31 ` Naoya Horiguchi
2012-08-23 20:31 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ehnecplx.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nhoriguc@redhat.com \
--cc=riel@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.