All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donald Hunter <donald.hunter@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net,  netdev@vger.kernel.org,
	 edumazet@google.com, pabeni@redhat.com,  andrew+netdev@lunn.ch,
	 horms@kernel.org, andrew@lunn.ch,  shuah@kernel.org,
	 kory.maincent@bootlin.com, sdf@fomichev.me,  gal@nvidia.com,
	 noren@nvidia.com, ahmed.zaki@intel.com,
	 wojciech.drewek@intel.com,  petrm@nvidia.com,
	danieller@nvidia.com,  linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 03/10] netlink: specs: ethtool: replace underscores with dashes in names
Date: Wed, 25 Jun 2025 10:51:37 +0100	[thread overview]
Message-ID: <m2frfocfo6.fsf@gmail.com> (raw)
In-Reply-To: <20250624211002.3475021-4-kuba@kernel.org>

Jakub Kicinski <kuba@kernel.org> writes:

> We're trying to add a strict regexp for the name format in the spec.
> Underscores will not be allowed, dashes should be used instead.
> This makes no difference to C (codegen replaces special chars in names)
> but gives more uniform naming in Python.
>
> Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
> Fixes: 46fb3ba95b93 ("ethtool: Add an interface for flashing transceiver modules' firmware")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>

  parent reply	other threads:[~2025-06-25 10:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 21:09 [PATCH net 00/10] netlink: specs: enforce strict naming of properties Jakub Kicinski
2025-06-24 21:09 ` [PATCH net 01/10] netlink: specs: nfsd: replace underscores with dashes in names Jakub Kicinski
2025-06-25  9:49   ` Donald Hunter
2025-06-25 11:35   ` Jeff Layton
2025-06-26 12:58   ` Chuck Lever
2025-06-24 21:09 ` [PATCH net 02/10] netlink: specs: fou: " Jakub Kicinski
2025-06-25  9:51   ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 03/10] netlink: specs: ethtool: " Jakub Kicinski
2025-06-24 23:07   ` Kory Maincent
2025-06-24 23:14     ` Jakub Kicinski
2025-06-25  9:51   ` Donald Hunter [this message]
2025-06-24 21:09 ` [PATCH net 04/10] netlink: specs: dpll: " Jakub Kicinski
2025-06-24 22:58   ` Vadim Fedorenko
2025-06-25  9:52   ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 05/10] netlink: specs: devlink: " Jakub Kicinski
2025-06-24 22:34   ` Jacob Keller
2025-06-25  9:52   ` Donald Hunter
2025-06-24 21:09 ` [PATCH net 06/10] netlink: specs: ovs_flow: " Jakub Kicinski
2025-06-25  9:52   ` Donald Hunter
2025-06-25 10:15   ` Ilya Maximets
2025-06-25 11:21   ` Eelco Chaudron
2025-06-24 21:09 ` [PATCH net 07/10] netlink: specs: mptcp: " Jakub Kicinski
2025-06-25  9:34   ` Davide Caratti
2025-06-25  9:53   ` Donald Hunter
2025-06-25 12:07   ` Matthieu Baerts
2025-06-24 21:10 ` [PATCH net 08/10] netlink: specs: rt-link: " Jakub Kicinski
2025-06-24 22:33   ` Jacob Keller
2025-06-25  9:54   ` Donald Hunter
2025-06-24 21:10 ` [PATCH net 09/10] netlink: specs: tc: " Jakub Kicinski
2025-06-25  9:54   ` Donald Hunter
2025-06-24 21:10 ` [PATCH net 10/10] netlink: specs: enforce strict naming of properties Jakub Kicinski
2025-06-25 10:05   ` Donald Hunter
2025-06-25 22:50 ` [PATCH net 00/10] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2frfocfo6.fsf@gmail.com \
    --to=donald.hunter@gmail.com \
    --cc=ahmed.zaki@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noren@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.