Re: [PATCH net 10/10] netlink: specs: enforce strict naming of properties

[Donald Hunter <donald.hunter@gmail.com>]

Jakub Kicinski <kuba@kernel.org> writes:

> Add a regexp to make sure all names which may end up being visible
> to the user consist of lower case characters, numbers and dashes.
> Underscores keep sneaking into the specs, which is not visible
> in the C code but makes the Python and alike inconsistent.
>
> Note that starting with a number is okay, as in C the full
> name will include the family name.
>
> For legacy families we can't enforce the naming in the family
> name or the multicast group names, as these are part of the
> binary uAPI of the kernel.
>
> For classic netlink we need to allow capital letters in names
> of struct members. TC has some structs with capitalized members.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>