All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] mmc: meson-gx: add support for HS400 mode
Date: Fri, 27 Jan 2017 10:55:19 -0800	[thread overview]
Message-ID: <m2fuk4uyco.fsf@baylibre.com> (raw)
In-Reply-To: <f7f325ec-6099-7f51-5bb4-24ac24073ee7@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 23:12:38 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> Add support for HS400 mode.
>
> Successfully tested on a Odroid C2 (S905 GXBB).
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Excellent!  Thanks for the patch.

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>

Some folks on IRC had reported that eMMC wasn't working on some boards
(like Amlogic P200) and with this patch, it's working again for me on P200.

@Andreas: does this patch fix your R-box Pro?

Kevin

> ---
>  drivers/mmc/host/meson-gx-mmc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 030425be..be45d57d 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -83,6 +83,7 @@
>  #define   CFG_RC_CC_MASK 0xf
>  #define   CFG_STOP_CLOCK BIT(22)
>  #define   CFG_CLK_ALWAYS_ON BIT(18)
> +#define   CFG_CHK_DS BIT(20)
>  #define   CFG_AUTO_CLK BIT(23)
>  
>  #define SD_EMMC_STATUS 0x48
> @@ -412,6 +413,16 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  	val &= ~(CFG_RC_CC_MASK << CFG_RC_CC_SHIFT);
>  	val |= ilog2(SD_EMMC_CFG_CMD_GAP) << CFG_RC_CC_SHIFT;
>  
> +	val &= ~CFG_DDR;
> +	if (ios->timing == MMC_TIMING_UHS_DDR50 ||
> +	    ios->timing == MMC_TIMING_MMC_DDR52 ||
> +	    ios->timing == MMC_TIMING_MMC_HS400)
> +		val |= CFG_DDR;
> +
> +	val &= ~CFG_CHK_DS;
> +	if (ios->timing == MMC_TIMING_MMC_HS400)
> +		val |= CFG_CHK_DS;
> +
>  	writel(val, host->regs + SD_EMMC_CFG);
>  
>  	if (val != orig)

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: meson-gx: add support for HS400 mode
Date: Fri, 27 Jan 2017 10:55:19 -0800	[thread overview]
Message-ID: <m2fuk4uyco.fsf@baylibre.com> (raw)
In-Reply-To: <f7f325ec-6099-7f51-5bb4-24ac24073ee7@gmail.com> (Heiner Kallweit's message of "Thu, 26 Jan 2017 23:12:38 +0100")

Heiner Kallweit <hkallweit1@gmail.com> writes:

> Add support for HS400 mode.
>
> Successfully tested on a Odroid C2 (S905 GXBB).
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Excellent!  Thanks for the patch.

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>

Some folks on IRC had reported that eMMC wasn't working on some boards
(like Amlogic P200) and with this patch, it's working again for me on P200.

@Andreas: does this patch fix your R-box Pro?

Kevin

> ---
>  drivers/mmc/host/meson-gx-mmc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 030425be..be45d57d 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -83,6 +83,7 @@
>  #define   CFG_RC_CC_MASK 0xf
>  #define   CFG_STOP_CLOCK BIT(22)
>  #define   CFG_CLK_ALWAYS_ON BIT(18)
> +#define   CFG_CHK_DS BIT(20)
>  #define   CFG_AUTO_CLK BIT(23)
>  
>  #define SD_EMMC_STATUS 0x48
> @@ -412,6 +413,16 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  	val &= ~(CFG_RC_CC_MASK << CFG_RC_CC_SHIFT);
>  	val |= ilog2(SD_EMMC_CFG_CMD_GAP) << CFG_RC_CC_SHIFT;
>  
> +	val &= ~CFG_DDR;
> +	if (ios->timing == MMC_TIMING_UHS_DDR50 ||
> +	    ios->timing == MMC_TIMING_MMC_DDR52 ||
> +	    ios->timing == MMC_TIMING_MMC_HS400)
> +		val |= CFG_DDR;
> +
> +	val &= ~CFG_CHK_DS;
> +	if (ios->timing == MMC_TIMING_MMC_HS400)
> +		val |= CFG_CHK_DS;
> +
>  	writel(val, host->regs + SD_EMMC_CFG);
>  
>  	if (val != orig)

  reply	other threads:[~2017-01-27 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 22:12 [PATCH] mmc: meson-gx: add support for HS400 mode Heiner Kallweit
2017-01-26 22:12 ` Heiner Kallweit
2017-01-27 18:55 ` Kevin Hilman [this message]
2017-01-27 18:55   ` Kevin Hilman
2017-02-06  9:32   ` Neil Armstrong
2017-02-06  9:32     ` Neil Armstrong
2017-02-06 18:28     ` Heiner Kallweit
2017-02-06 18:28       ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fuk4uyco.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.