From: Kevin Hilman <khilman@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>,
Axel Haslam <ahaslam@baylibre.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
Andy Gross <andy.gross@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/4] PM / Domains: Remove redundant call to pm_request_idle() in genpd
Date: Mon, 23 May 2016 14:25:43 -0700 [thread overview]
Message-ID: <m2h9domppk.fsf@baylibre.com> (raw)
In-Reply-To: <1463485296-22742-2-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 17 May 2016 13:41:33 +0200")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> The PM core increases the runtime PM usage count at the system PM prepare
> phase. Later when the system has resumed and the ->complete() callback has
> been invoked, it drops the usage count. In this way, it intentionally
> prevents runtime PM suspend for the device throughout this period.
>
> For this reason, let's remove the call to pm_request_idle() from within
> genpd's ->complete() calllback as it's redundant.
It's not obvious from this description why the pm_request_idle() is
redundant based just on usage count.
IIUC, I think what you mean is that it's redundant because
device_complete() does a pm_runtime_put(), which, in addition to
decrementing the usage count, will do the equivalent of
pm_request_idle()?
Kevin
next prev parent reply other threads:[~2016-05-23 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 11:41 [PATCH 0/4] PM / Domains / Runtime: Optimize device system PM when using genpd Ulf Hansson
2016-05-17 11:41 ` [PATCH 1/4] PM / Domains: Remove redundant call to pm_request_idle() in genpd Ulf Hansson
2016-05-23 21:25 ` Kevin Hilman [this message]
2016-05-24 6:19 ` Ulf Hansson
2016-05-17 11:41 ` [PATCH 2/4] PM / Runtime: Prevent re-resuming devices in pm_runtime_force_resume() Ulf Hansson
2016-05-23 21:30 ` Kevin Hilman
2016-05-24 6:30 ` Ulf Hansson
2016-05-24 18:31 ` Kevin Hilman
2016-05-17 11:41 ` [PATCH 3/4] PM / Domains: Allow runtime PM during system PM phases Ulf Hansson
2016-05-23 23:06 ` Kevin Hilman
2016-05-24 6:40 ` Ulf Hansson
2016-05-17 11:41 ` [PATCH 4/4] PM / Runtime: Defer resuming of the device in pm_runtime_force_resume() Ulf Hansson
2016-05-23 23:15 ` Kevin Hilman
2016-05-24 6:51 ` Ulf Hansson
2016-05-24 18:34 ` Kevin Hilman
2016-06-28 16:26 ` Geert Uytterhoeven
2016-06-29 0:26 ` Rafael J. Wysocki
2016-06-29 17:30 ` Ulf Hansson
2016-07-04 13:57 ` Geert Uytterhoeven
2016-06-30 22:40 ` Kevin Hilman
2016-07-04 13:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2h9domppk.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=andy.gross@linaro.org \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.