Re: [PATCH 2/4] PM / Runtime: Prevent re-resuming devices in pm_runtime_force_resume()

[Kevin Hilman <khilman@baylibre.com>]

Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 23 May 2016 at 23:30, Kevin Hilman <khilman@baylibre.com> wrote:
>> Ulf Hansson <ulf.hansson@linaro.org> writes:
>>
>>> If the device has already been resumed before pm_runtime_force_resume() is
>>> invoked, prevent calling the ->runtime_resume() callback for the device,
>>> as it's not the expected behaviour from the subsystem/driver.
>>
>> I'm not following how this description matches the code.
>>
>> Based on the code, it seems like it should say "If the device has not
>> been runtime suspended, don't runtime resume it."   IOW, "device has
>> already been resumed" is not what pm_runtime_status_suspended() is
>> checking for.
>
> Hmm, these helpers are executed during the system PM sequence to
> re-use the ->runtime_suspend|resume() callbacks to suspend and resume
> the device.
> The message is the change log do become a bit confusing because of
> that, what do you think about the below instead?
>
> If the runtime PM status of the device isn't runtime suspended, prevent
> pm_runtime_force_resume() to call the ->runtime_resume() callback for the
> device, as it's not the expected behaviour from the subsystem/driver.

Yeah, that's clearer.  Thanks.

Kevin