From: Hajime Tazaki<thehajime@gmail.com>
To: paullawrence@google.com
Cc: richard@nod.at, jdike@addtoit.com, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, krisman@collabora.com,
chris.obbard@collabora.com, anton.ivanov@cambridgegreys.com
Subject: Re: [PATCH] um: ubd: Fix crash from option parsing
Date: Fri, 22 Jan 2021 09:41:19 +0900 [thread overview]
Message-ID: <m2im7pyf9s.wl-thehajime@gmail.com> (raw)
In-Reply-To: <20210119181945.2071053-1-paullawrence@google.com>
Hello,
On Wed, 20 Jan 2021 03:19:45 +0900,
Paul Lawrence wrote:
>
> Below patch will cause NULL ptr dereferences if the optional filenames
> are not present.
>
> Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline)
> Signed-off-by: Paul Lawrence <paullawrence@google.com>
This was addressed/fixed by the below patch, though that one doesn't
the first "file" variable check.
http://lists.infradead.org/pipermail/linux-um/2020-December/000983.html
There was another attempt to fix (with the same diff), btw.
http://lists.infradead.org/pipermail/linux-um/2021-January/000998.html
It seems that the patch is already queued but not upstreamed yet.
-- Hajime
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Hajime Tazaki <thehajime@gmail.com>
To: paullawrence@google.com
Cc: jdike@addtoit.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, krisman@collabora.com,
chris.obbard@collabora.com, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: ubd: Fix crash from option parsing
Date: Fri, 22 Jan 2021 09:41:19 +0900 [thread overview]
Message-ID: <m2im7pyf9s.wl-thehajime@gmail.com> (raw)
In-Reply-To: <20210119181945.2071053-1-paullawrence@google.com>
Hello,
On Wed, 20 Jan 2021 03:19:45 +0900,
Paul Lawrence wrote:
>
> Below patch will cause NULL ptr dereferences if the optional filenames
> are not present.
>
> Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline)
> Signed-off-by: Paul Lawrence <paullawrence@google.com>
This was addressed/fixed by the below patch, though that one doesn't
the first "file" variable check.
http://lists.infradead.org/pipermail/linux-um/2020-December/000983.html
There was another attempt to fix (with the same diff), btw.
http://lists.infradead.org/pipermail/linux-um/2021-January/000998.html
It seems that the patch is already queued but not upstreamed yet.
-- Hajime
next prev parent reply other threads:[~2021-01-22 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:19 [PATCH] um: ubd: Fix crash from option parsing Paul Lawrence
2021-01-19 18:19 ` Paul Lawrence
2021-01-19 18:35 ` Gabriel Krisman Bertazi
2021-01-19 18:35 ` Gabriel Krisman Bertazi
2021-01-22 0:41 ` Hajime Tazaki [this message]
2021-01-22 0:41 ` Hajime Tazaki
2021-01-22 14:44 ` Paul Lawrence
2021-01-22 14:44 ` Paul Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2im7pyf9s.wl-thehajime@gmail.com \
--to=thehajime@gmail.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=chris.obbard@collabora.com \
--cc=jdike@addtoit.com \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=paullawrence@google.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.