From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: multi_v7_defconfig: Switch AXP20x driver from module to built-in
Date: Tue, 30 May 2017 21:26:20 -0700 [thread overview]
Message-ID: <m2inkhr6s3.fsf@baylibre.com> (raw)
In-Reply-To: <20170522074414.3qz2wpw4cs2btkhv@flea.lan> (Maxime Ripard's message of "Mon, 22 May 2017 09:44:14 +0200")
Maxime Ripard <maxime.ripard@free-electrons.com> writes:
> Hi Kevin,
>
> On Thu, May 18, 2017 at 11:59:50AM -0700, Kevin Hilman wrote:
>> On Fri, Mar 17, 2017 at 10:39 AM, Kevin Hilman <khilman@baylibre.com> wrote:
>> > On Fri, Feb 10, 2017 at 12:42 AM, Maxime Ripard
>> > <maxime.ripard@free-electrons.com> wrote:
>> >> On Wed, Feb 08, 2017 at 11:09:31PM +0100, Rask Ingemann Lambertsen wrote:
>> >>> The AXP20X regulator support is currently built as a module, which means
>> >>> it's not available until the root fs has been mounted, but the boot loader
>> >>> might not have enabled the required regulators, so build their drivers
>> >>> into the kernel.
>> >>>
>> >>> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
>> >>
>> >> Queued for 4.12.
>> >
>> > Hello, kernelci.org is reporting boot failures on sun5i-r8-chip in
>> > linux-next[1] for a few days and with a variety of defconfigs. I
>> > bisected it[2] down to this patch.
>> >
>> > I verified that reverting this patch on top of next-20170310 makes my
>> > chip board boot again.
>>
>> FYI... this board is still broken in linux-next (and now in mainline),
>> and reverting $SUBJECT patch still makes it work.
>>
>> Is nobody else using mainline on this board?
>
> I thought about that during the weekend, and it might just be a
> symptom.
>
> The CHIP has brown out issues, especially when you enable the WiFi
> chip, which should happen around the time of the failure when the PMIC
> regulator support is compiled as a module.
>
> We mitigate that in upstream's U-Boot by enabling the two regulators
> for the WiFi chip in U-boot, which levels a bit the current over the
> boot.
How recent of a mainline u-boot do I need? I'm currently running
v2016.01.
> You have a few ways to prevent that from happening. Having a better
> power supply / cable will help, I'm not sure how reasonable that is.
>
> Another thing that can work is, if your USB plugs can take it, to
> increase the overcurrent trigger in the PMIC, ideally in U-Boot.
>
> The last, and probably cleaner one, would be to just power it through
> the 5v input on its header, and not the USB. There's not current
> limitation there, so it shouldn't cause any problems anymore.
OK, I can look into powering via 5V input also.
Just curious: which of the above methods are you using?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Rask Ingemann Lambertsen <rask@formelder.dk>,
Chen-Yu Tsai <wens@csie.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM: multi_v7_defconfig: Switch AXP20x driver from module to built-in
Date: Tue, 30 May 2017 21:26:20 -0700 [thread overview]
Message-ID: <m2inkhr6s3.fsf@baylibre.com> (raw)
In-Reply-To: <20170522074414.3qz2wpw4cs2btkhv@flea.lan> (Maxime Ripard's message of "Mon, 22 May 2017 09:44:14 +0200")
Maxime Ripard <maxime.ripard@free-electrons.com> writes:
> Hi Kevin,
>
> On Thu, May 18, 2017 at 11:59:50AM -0700, Kevin Hilman wrote:
>> On Fri, Mar 17, 2017 at 10:39 AM, Kevin Hilman <khilman@baylibre.com> wrote:
>> > On Fri, Feb 10, 2017 at 12:42 AM, Maxime Ripard
>> > <maxime.ripard@free-electrons.com> wrote:
>> >> On Wed, Feb 08, 2017 at 11:09:31PM +0100, Rask Ingemann Lambertsen wrote:
>> >>> The AXP20X regulator support is currently built as a module, which means
>> >>> it's not available until the root fs has been mounted, but the boot loader
>> >>> might not have enabled the required regulators, so build their drivers
>> >>> into the kernel.
>> >>>
>> >>> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
>> >>
>> >> Queued for 4.12.
>> >
>> > Hello, kernelci.org is reporting boot failures on sun5i-r8-chip in
>> > linux-next[1] for a few days and with a variety of defconfigs. I
>> > bisected it[2] down to this patch.
>> >
>> > I verified that reverting this patch on top of next-20170310 makes my
>> > chip board boot again.
>>
>> FYI... this board is still broken in linux-next (and now in mainline),
>> and reverting $SUBJECT patch still makes it work.
>>
>> Is nobody else using mainline on this board?
>
> I thought about that during the weekend, and it might just be a
> symptom.
>
> The CHIP has brown out issues, especially when you enable the WiFi
> chip, which should happen around the time of the failure when the PMIC
> regulator support is compiled as a module.
>
> We mitigate that in upstream's U-Boot by enabling the two regulators
> for the WiFi chip in U-boot, which levels a bit the current over the
> boot.
How recent of a mainline u-boot do I need? I'm currently running
v2016.01.
> You have a few ways to prevent that from happening. Having a better
> power supply / cable will help, I'm not sure how reasonable that is.
>
> Another thing that can work is, if your USB plugs can take it, to
> increase the overcurrent trigger in the PMIC, ideally in U-Boot.
>
> The last, and probably cleaner one, would be to just power it through
> the 5v input on its header, and not the USB. There's not current
> limitation there, so it shouldn't cause any problems anymore.
OK, I can look into powering via 5V input also.
Just curious: which of the above methods are you using?
Kevin
next prev parent reply other threads:[~2017-05-31 4:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 22:07 [PATCH 1/4] ARM: sunxi_defconfig: Enable AC100 RTC driver Rask Ingemann Lambertsen
2017-02-08 22:07 ` Rask Ingemann Lambertsen
2017-02-08 22:08 ` [PATCH 2/4] ARM: multi_v7_defconfig: Switch sunxi RSB driver from module to built-in Rask Ingemann Lambertsen
2017-02-08 22:08 ` Rask Ingemann Lambertsen
2017-02-10 8:41 ` Maxime Ripard
2017-02-10 8:41 ` Maxime Ripard
2017-02-08 22:08 ` [PATCH 3/4] ARM: multi_v7_defconfig: Enable AC100 RTC driver Rask Ingemann Lambertsen
2017-02-08 22:08 ` Rask Ingemann Lambertsen
2017-02-10 8:41 ` Maxime Ripard
2017-02-10 8:41 ` Maxime Ripard
2017-02-08 22:09 ` [PATCH 4/4] ARM: multi_v7_defconfig: Switch AXP20x driver from module to built-in Rask Ingemann Lambertsen
2017-02-08 22:09 ` Rask Ingemann Lambertsen
2017-02-10 8:42 ` Maxime Ripard
2017-02-10 8:42 ` Maxime Ripard
2017-03-17 17:39 ` Kevin Hilman
2017-03-17 17:39 ` Kevin Hilman
2017-05-18 18:59 ` Kevin Hilman
2017-05-18 18:59 ` Kevin Hilman
2017-05-22 7:44 ` Maxime Ripard
2017-05-22 7:44 ` Maxime Ripard
2017-05-31 4:26 ` Kevin Hilman [this message]
2017-05-31 4:26 ` Kevin Hilman
2017-06-06 19:45 ` Kevin Hilman
2017-06-06 19:45 ` Kevin Hilman
2017-06-10 16:17 ` Maxime Ripard
2017-06-10 16:17 ` Maxime Ripard
2017-06-13 16:14 ` Kevin Hilman
2017-06-13 16:14 ` Kevin Hilman
2017-06-14 7:07 ` Maxime Ripard
2017-06-14 7:07 ` Maxime Ripard
2017-07-21 14:17 ` Maxime Ripard
2017-07-21 14:17 ` Maxime Ripard
2017-07-22 19:14 ` Kevin Hilman
2017-07-22 19:14 ` Kevin Hilman
2017-02-10 8:41 ` [PATCH 1/4] ARM: sunxi_defconfig: Enable AC100 RTC driver Maxime Ripard
2017-02-10 8:41 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2inkhr6s3.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.